Correct poor grammar in wallet synchronization warning. #720

This pull request updates the wallet synchronization warning text to provide a clearer and more concise message to users. The original text was somewhat clumsy and suffered from grammatical issues, which could lead to confusion. The changes made are as follows:

• Replace the original warning text with a more concise and grammatically correct version.
• Clarify that transactions using bitcoin from unseen transactions due to ongoing synchronization will be rejected by the network.

These changes aim to improve user experience by providing clearer information about potential issues related to wallet synchronization.

Old text: "Recent transactions may not yet be visible, and therefore your wallet's balance might be incorrect. This information will be correct once your wallet has finished synchronizing with the bitcoin network, as detailed below. Attempting to spend bitcoins that are affected by not-yet-displayed transactions will not be accepted by the network."

New text: "Wallet balance may be inaccurate during synchronization, as recent transactions may still be loading (details below). Caution: Transactions using bitcoin from unseen transactions (due to ongoing synchronization) will be rejected by the network."

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Translation files should be modified during the translation process only. Please drop those changes from this PR.

If these files aren't changed then the translations would break, wouldn't they?

On Wed, 15 Mar 2023, 19:27 Hennadii Stepanov, @.***> wrote:

Translation files should be modified during the translation process only. Please drop those changes from this PR.

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/720#issuecomment-1470692898, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALVTK574WMIXB74LQ2VMXDW4IJ2VANCNFSM6AAAAAAV4AB3JE . You are receiving this because you authored the thread.Message ID: @.***>

If these files aren't changed then the translations would break, wouldn't they?

The bitcon_<LANGUAGE>.ts translation files are updated by bitcoin-maintainer-tools/update-translations.py tool. For example, see https://github.com/bitcoin/bitcoin/pull/27251.

Updating <source> strings without updating <translation> ones do break translations.

The meaning hasn't changed though, just the grammar, so the existing translations in other languages are still good. Can the existing translations be retained if I delete the translation file changes?

On Thu, 16 Mar 2023, 09:55 Hennadii Stepanov, @.***> wrote:

If these files aren't changed then the translations would break, wouldn't they?

The bitcon_<LANGUAGE>.ts translation files are updated by bitcoin-maintainer-tools/update-translations.py https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/main/update-translations.py tool. For example, see bitcoin/bitcoin#27251 https://github.com/bitcoin/bitcoin/pull/27251.

Updating <source> strings without updating <translation> ones do break translations.

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471636284, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALVTK2DUIQO5EKZWVEWPC3W4LPQ7ANCNFSM6AAAAAAV4AB3JE . You are receiving this because you authored the thread.Message ID: @.***>

Can the existing translations be retained if I delete the translation file changes?

If the suggested changes to the src/qt/forms/modaloverlay.ui file will be merged, during the next translation cycle translators will see the updated strings being marked as "untranslated". Therefore, they have to translate them again, which is, actually, an additional burden. And *.ts translation files will be updated regardless of your manual update. Therefore, it looks just pointless.

So, how are we supposed to change just the English language in a change without affecting other languages?

I guess we first need to make a change to that script to allow this functionality.

FYI: the new wording was generated by GPT-4, and educated on how bitcoin works as part of this process. Therefore it should be quite possible to generate the translations automatically using this method.

On Thu, 16 Mar 2023, 10:09 Hennadii Stepanov, @.***> wrote:

Can the existing translations be retained if I delete the translation file changes?

If the suggested changes to the src/qt/forms/modaloverlay.ui file will be merged, during the next translation cycle translators will see the updated strings being marked as "untranslated". Therefore, they have to translate them again, which is, actually, an additional burden. And *.ts translation files will be updated regardless of your manual update. Therefore, it looks just pointless.

— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/gui/pull/720#issuecomment-1471659745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALVTK3KGEUAXSXHKMZUC6LW4LRFDANCNFSM6AAAAAAV4AB3JE . You are receiving this because you authored the thread.Message ID: @.***>

So, how are we supposed to change just the English language in a change without affecting other languages?

I don't think it is feasible with the current translation process/tools.

FYI: the new wording was generated by GPT-4, and educated on how bitcoin works as part of this process.

That means it has a dubious copyright status and can't be used in the first place. Please don't do that.

FYI: the new wording was generated by GPT-4, and educated on how bitcoin works as part of this process.

That means it has a dubious copyright status and can't be used in the first place. Please don't do that. @luke-jr https://youtu.be/roiOLaXr-os - GPT-4 is actually less likely to breach copyright than an organic human is.