Show own outputs on PSBT signing window #740

1. 
   hernanmarino commented at 6:20 am on June 21, 2023: contributor

   This fixes #732 . It allows you to identify your own addresses in the outputs of a transaction in the PSBT signing window. This enables easy identification of change outputs, and prevents certain attacks where someone (co-signers of a multisig, or others ) might trick you into signing a transaction while they are stealing the change, since prior to this modification there was no easy way of knowing this.

   The identification of the output is similar to the way this is done in the transaction details window.

   A sample output is :

   

2. qt: show own outputs on PSBT signing window 4da243ba02
3. 
   DrahtBot commented at 6:20 am on June 21, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	jarolrod, achow101
   Concept ACK	kallerosenbaum, pablomartin4btc

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

4. 
   kallerosenbaum commented at 2:14 pm on June 21, 2023: none

   Concept ACK

   Tested on regtest. Works as described and it does indeed fix #732.

5. 
   pablomartin4btc commented at 5:01 pm on June 21, 2023: contributor

   Tested ACK on signet, both, @kallerosenbaum’s use case (where you have a watch-only wallet “online” and you sign the tx “offline”, then you will need to broadcast it ofc) and a multisig wallet case mentioned by @hernanmarino in the description of this PR, work as expected. Perhaps it would be more noticeable if the colour of the added text “(own address)” is changed? Also, I couldn’t find any test using txoutIsMine(), although there are for IsMine().

   edit: forgot to mention, for the multisig wallet use case, one should create it with the own private key and the public key/ s from the other signers, so when we select it and check the PBST it will be shown the “own address” text in the tx window.

6. 
   jarolrod commented at 7:12 am on July 5, 2023: member

   ACK 4da243ba023f2987e97fc62886c6ebc70d6ee50a

   Tested for functionality, and confirmed new translation added here shows up when building translations.

7. jarolrod requested review from achow101 on Jul 5, 2023
8. 
   achow101 commented at 11:00 pm on July 14, 2023: member

   ACK 4da243ba023f2987e97fc62886c6ebc70d6ee50a
9. DrahtBot removed review request from achow101 on Jul 14, 2023
10. hebasto merged this on Jul 16, 2023
11. hebasto closed this on Jul 16, 2023

    ---

12. sidhujag referenced this in commit dc6b1250d4 on Jul 17, 2023
13. bitcoin-core locked this on Jul 15, 2024

Contributors
hernanmarino DrahtBot kallerosenbaum pablomartin4btc jarolrod achow101