Transaction details “virtual size” does not account for sigops #750

issue luke-jr openend this issue on August 25, 2023
  1. luke-jr commented at 2:58 am on August 25, 2023: member
    0    strHTML += "<b>" + tr("Transaction virtual size") + ":</b> " + QString::number(GetVirtualTransactionSize(*wtx.tx)) + " bytes<br>";
    

    GetVirtualTransactionSize fails to account for sigops if passed the transaction alone.

    This could confuse a user into thinking the transaction they were sent, still unconfirmed, has a reasonable fee rate, when it might very well not due to a bunch of sigops in another output or input.

    Annoyingly, GetTransactionSigOpCost looks liable to assert if used on a confirmed transaction. It wouldn’t make sense to stop reporting the correct virtual size after a transaction confirms, so this looks like a pain to fix.

  2. luke-jr added the label Bug on Aug 25, 2023


luke-jr

Labels
Bug


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-01 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me