Update Node window title with the chain type #758

1. 
   pablomartin4btc commented at 4:05 pm on September 17, 2023: contributor

   It fixes #544.

   Enhance the Node window title by appending the chain type to it, except for the mainnet, mirroring the behavior in the main window.

   

   There was also some interest on this while discussing network switching.

2. 
   DrahtBot commented at 4:05 pm on September 17, 2023: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	MarnixCroes, hernanmarino, BrandonOdiwuor, alfonsoromanz, kristapsk, hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. pablomartin4btc force-pushed on Sep 17, 2023
4. DrahtBot added the label CI failed on Sep 17, 2023
5. pablomartin4btc force-pushed on Sep 17, 2023
6. pablomartin4btc force-pushed on Sep 17, 2023
7. pablomartin4btc force-pushed on Sep 17, 2023
8. DrahtBot removed the label CI failed on Sep 18, 2023
9. gui: Update Node window title with chain type

   Update Node window with the chain type except for mainnet.
   This replicates the behaviour of the main window.

   9d37886a3b
10. pablomartin4btc force-pushed on Sep 18, 2023
11. DrahtBot added the label CI failed on Sep 18, 2023
12. DrahtBot removed the label CI failed on Sep 18, 2023
13. MarnixCroes approved
14. 
    MarnixCroes commented at 4:58 pm on September 23, 2023: contributor

    tACK 9d37886a3b6ce24f4a4a05193eb0d071655a8457
15. hernanmarino approved
16. 
    hernanmarino commented at 9:22 pm on October 6, 2023: contributor

    tACK 9d37886a3b6ce24f4a4a05193eb0d071655a8457
17. 
    BrandonOdiwuor commented at 11:07 am on November 17, 2023: contributor

    Is this a platform specific issue?

    This currently how my GUI behaves on master branch. [Platform: Ubuntu: 22]

    [testnet]

    [regtest]

    [signet]

18. 
    pablomartin4btc commented at 2:49 pm on November 17, 2023: contributor

    Thanks @BrandonOdiwuor for testing it.

    Main window is fine, this PR updates the title on the node window (e.g.: Main Menu->Window->Console).

    Is this a platform specific issue?

    It should work on any platform.

19. BrandonOdiwuor approved
20. 
    BrandonOdiwuor commented at 2:20 pm on November 20, 2023: contributor

    tested ACK 9d37886a3b6ce24f4a4a05193eb0d071655a8457

    

21. DrahtBot added the label CI failed on Dec 5, 2023
22. DrahtBot removed the label CI failed on Dec 6, 2023
23. alfonsoromanz approved
24. 
    alfonsoromanz commented at 10:00 pm on December 22, 2023: none

    Tested ACK https://github.com/bitcoin-core/gui/pull/758/commits/9d37886a3b6ce24f4a4a05193eb0d071655a8457

25. kristapsk approved
26. 
    kristapsk commented at 7:05 pm on December 27, 2023: contributor

    ACK 9d37886a3b6ce24f4a4a05193eb0d071655a8457
27. DrahtBot added the label CI failed on Jan 14, 2024
28. in src/qt/rpcconsole.cpp:1382 in 9d37886a3b

    1377+    if (chain == ChainType::MAIN) return;
    1378+
    1379+    const QString chainType = QString::fromStdString(Params().GetChainTypeString());
    1380+    const QString title = tr("Node window - [%1]").arg(chainType);
    1381+    this->setWindowTitle(title);
    1382+}
    

    ---

    ---

    

    hebasto commented at 1:04 pm on February 12, 2024:

    nit: Missed EOL.
29. hebasto approved
30. 
    hebasto commented at 1:04 pm on February 12, 2024: member

    ACK 9d37886a3b6ce24f4a4a05193eb0d071655a8457, tested on Ubuntu 23.10.
31. hebasto merged this on Feb 12, 2024
32. hebasto closed this on Feb 12, 2024

    ---

33. jess2505 approved

Contributors
pablomartin4btc DrahtBot MarnixCroes hernanmarino BrandonOdiwuor alfonsoromanz kristapsk hebasto jess2505

Labels
CI failed