Avoid error-prone leading whitespace in translatable strings #771

pull hebasto wants to merge 3 commits into bitcoin-core:master from hebasto:231023-space changing 6 files +36 −11
  1. hebasto commented at 2:07 pm on October 23, 2023: member

    While working on the GUI translation via Transifex web interface, I found it error-prone to have leading whitespace in translatable strings. This is because it is very easy to unintentionally drop them in translations unnoticed.

    Fixed all current cases. Added a linter to prevent similar cases in the future.

  2. qt, refactor: Drop superfluous type conversions d8298e7f06
  3. qt: Avoid error prone leading spaces in translatable strings 294a018bf5
  4. lint: Add `lint-qt-translation.py` 856325fac1
  5. DrahtBot commented at 2:08 pm on October 23, 2023: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK furszy

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. hebasto added the label Tests on Oct 23, 2023
  7. hebasto added the label Translations on Oct 23, 2023
  8. DrahtBot added the label CI failed on Oct 23, 2023
  9. furszy commented at 6:45 pm on October 23, 2023: member
    utACK 856325f
  10. DrahtBot removed the label CI failed on Oct 25, 2023
  11. hebasto merged this on Oct 25, 2023
  12. hebasto closed this on Oct 25, 2023

  13. bitcoin-core locked this on Oct 24, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me