Second part: Fixes #769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
overview page when avoid_reuse is enabled
overview page when avoid_reuse is not enabled
Add used balance to overview page for wallets with avoid_reuse flag enabled
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| Concept ACK | katesalazar, pablomartin4btc |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
183+ </property>
184+ <property name="toolTip">
185+ <string>Your current used balance</string>
186+ </property>
187+ <property name="text">
188+ <string notr="true">21 000 000.00000000 BTC</string>
180+ <widget class="QLabel" name="labelUsed">
181+ <property name="cursor">
182+ <cursorShape>IBeamCursor</cursorShape>
183+ </property>
184+ <property name="toolTip">
185+ <string>Your current used balance</string>
Because the space is tiny, and the impact should be big, every word in an effective tooltip needs to pack a punch.
Source: Internet
as the tooltip for the “used” line of the “balances” block, “your current used balance” doesnt feel like a great tooltip
Concept ACK
As mentioned on the first part/ core PR, please consider to add the wallet interface commit as the very first commit here on this PR so it’s easier to test this new feature.
🤔 There hasn’t been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.
Second part: Fixes #769
Add used balance to the overview page for wallets with the avoid_reuse flag enabled
Prerequsite:
- Part one (should be merged first): Wallet: Functions to enable adding used balance to GUI overview page bitcoin/bitcoin#28776
If you are still working on this PR, please address https://github.com/bitcoin/bitcoin/pull/28776#discussion_r1557805199.
@hebasto Sorry I will be updating the PR description
There was a change in implementation. I created a different PR (https://github.com/bitcoin/bitcoin/pull/29062) based on the recommendation to refactor the getbalance() function which touches the bitcoin repo. trying to get it merged so that I can update this PR
There was a change in implementation. I created a different PR (bitcoin/bitcoin#29062) based on the recommendation to refactor the
getbalance()function which touches the bitcoin repo. trying to get it merged so that I can update this PR
Okay. Until then, marking this PR as a draft.
🤔 There hasn’t been much activity lately and the CI seems to be failing.
If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.