FIX:When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets' names.

xonx4l commented at 6:30 pm on January 10, 2024: none

issue-: #259

The “Opening Wallet” popup would now show “Opening Wallet: " instead of just “Opening Wallet”. This identifies the specific wallet.

The “Rescanning” popup would show “Rescanning: " or “Rescanning - 0%” if a progress bar is added. Again, this identifies the wallet.

The main window title would include the wallet name after being opened/loaded thanks to the change in WalletView::showNormalIfMinimized().

Other dialogs like Send/Receive coins would also show the wallet name in the title.

So in summary, by appending the wallet name retrieved from WalletModel::getWalletName() to titles and popup messages, it provides clearer feedback to users about which wallet is being loaded and rescanned. No more confusion about which wallet Bitcoin Core is working on.

Update sendcoinsdialog.cpp

issue-: #259

3573708656

DrahtBot commented at 6:30 pm on January 10, 2024: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Update receivecoinsdialog.cpp 4e1c91352e

DrahtBot added the label CI failed on Jan 10, 2024

in src/qt/receivecoinsdialog.cpp:75 in 4e1c91352e

71@@ -72,6 +72,9 @@ void ReceiveCoinsDialog::setModel(WalletModel *_model)
72 {
73     this->model = _model;
74 
75+        setWindowTitle(tr("Request payments - %1").arg(model->getWalletName()));

pablomartin4btc commented at 2:54 am on January 21, 2024:

CI lint is failing due to unnecessary white-spaces in the files (you can run the script lint-whitespace.py locally or even all linters)

0    setWindowTitle(tr("Request payments - %1").arg(model->getWalletName()));

pablomartin4btc commented at 2:54 am on January 21, 2024: contributor

Thanks @xonx4l for working on this.

I don’t think this PR fixes #259 as, according to its description and what I understand, a fix should be add more clarification (percentage?) about the rescanning of a wallet when they get open in 2 situations:

During bitcoin-qt startup, as author of the PR specified, the user could add the wallets manually into the settings.json qt config file. In this case, perhaps the name of each wallet (if there are many, and may be also x/ total) should be added after the “rescanning…” text on the spash-screen (initial/ startup window).
When a user open a wallet for the first time thru the menu->File->Open Wallet. For this case, perhaps a “rescanning…” (and maybe a % or progress bar - check issue #679) text could be added at the bottom of the opening window. @hebasto on his comment on the issue, mentioned to add the wallet name on the title of “Receiving addresses” & “Sending addresses” windows (which has been done and merged already on #757), not to the receivecoins or sendcoins dialogs which this PR changes, moreover since these dialogs are within the main window and titles won’t be displayed:

Other than that, the title and description of the PR doesn’t reflect the proper change that’s making, please check the contributor and developer guidelines (e.g. commit name may start with prefix gui:, please check other PRs as reference).

Please don’t get discouraged by these observations. Feel free to reach out if you have questions or need clarification on any points. I encourage you to continue working on this issue or any others. Thanks again!

DrahtBot commented at 1:06 am on April 20, 2024: contributor

🤔 There hasn’t been much activity lately and the CI seems to be failing.

If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

DrahtBot commented at 0:50 am on August 2, 2024: contributor

🤔 There hasn’t been much activity lately and the CI seems to be failing.

If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn’t been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in.

hebasto commented at 4:17 pm on August 12, 2024: member

Closing due to lack of support from the PR author (unaddressed comments, failed CI).

Feel free to re-open.

hebasto closed this on Aug 12, 2024

FIX:When opening or autoloading wallets there should be clear messages about rescanning in progress and wallets’ names. #786

Reviews