Using the windows.h header guarantees correctness regardless of the content of other headers.
For more details, please refer to https://stackoverflow.com/questions/4845198/fatal-error-no-target-architecture-in-visual-studio
Fixes the MSVC build when using the upcoming CMake-based build system and Qt packages installed via the vcpkg package manager.
Related to https://github.com/hebasto/bitcoin/pull/77.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | theuni |
| Stale ACK | sipsorcery |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
I don’t disagree with using self-contained headers, but according to your link it should only be necessary if we don’t define WIN32_LEAN_AND_MEAN, which we do.
So, this makes me think there must be some compilation units where this somehow doesn’t get defined?
So, this makes me think there must be some compilation units where this somehow doesn’t get defined?
I suppose, they might be the qt* stuff built by vcpkg.
You might be interested to consider the following example: https://godbolt.org/z/b8rns1e6x
Using the `windows.h` header guarantees correctness regardless of the
content of other headers.
For more details, please refer to https://stackoverflow.com/questions/4845198/fatal-error-no-target-architecture-in-visual-studio
Fixes the MSVC build when using the upcoming CMake-based build system
and Qt packages installed via the vcpkg package manager.
9@@ -10,7 +10,7 @@
10 #include <QString>
11 #include <functional>
12
13-#include <windef.h> // for HWND
14+#include <windows.h> // for HWND
Comment should be removed?
Thanks! Done.
windows.h seems more correct regardless.