refactor: Readable widget naming for debug window #790
pull s1Sharp wants to merge 1 commits into bitcoin-core:master from s1Sharp:debug_window changing 2 files +37 −40-
s1Sharp commented at 8:23 pm on January 21, 2024: noneFixed widget names in the debug window. Make it more developer friendly to avoid confusion inside Qt Designer.
-
refactor: Readable widget naming for debug window 5c445cb6b2
-
DrahtBot commented at 8:23 pm on January 21, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #626 (Showing Local Addresses in Node Window by jadijadi)
- #bitcoin/bitcoin/28956 (Nuke adjusted time (attempt 2) by dergoegge)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
s1Sharp commented at 8:27 pm on January 21, 2024: none
Qt Designer view before changes: Qt Designer view after changes:
And a few changes for other widget names that were not included in the screenshots.
Also property indent is unnessasary for QLabel: labelClientUserAgent
0 <property name="indent"> 1 <number>10</number> 2 </property>
-
DrahtBot cross-referenced this on Jan 21, 2024 from issue Showing Local Addresses in Node Window by jadijadi
-
DrahtBot cross-referenced this on Jan 21, 2024 from issue Nuke adjusted time (attempt 2) by dergoegge
-
hebasto commented at 10:43 am on January 22, 2024: member
Thank you for your contribution!
However, I’m going to close this PR following our CONTRIBUTING Guide and to avoid unnecessary conflicts with other PRs.
-
hebasto closed this on Jan 22, 2024
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 09:20 UTC
More mirrored repositories can be found on mirror.b10c.me