if desired, can also update ORG_NAME
to Bitcoin Core
guiconstants: update ORG_DOMAIN to bitcoincore.org #818
pull MarnixCroes wants to merge 1 commits into bitcoin-core:master from MarnixCroes:ORG_DOMAIN changing 1 files +1 −1-
MarnixCroes commented at 7:00 pm on April 24, 2024: contributor
-
qt/guiconstants: update ORG_DOMAIN to bitcoincore.org 1b7abd2e4e
-
DrahtBot commented at 7:00 pm on April 24, 2024: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
-
laanwj commented at 7:31 pm on April 24, 2024: member
if desired, can also update ORG_NAME to Bitcoin Core
The reason that this was never done is because it changes where the Qt settings files are stored. For example this is
~/.config/<ORG_NAME>/<APP_NAME>
on Linux.i’m not sure what actually is the effect of changing the domain, but this shouldn’t be done without checking what it is used for.
-
hebasto commented at 7:49 pm on April 24, 2024: member
if desired, can also update
ORG_NAME
to Bitcoin CoreAre there any issues with the current code? If not, then this PR lacks motivation.
-
MarnixCroes commented at 0:04 am on April 25, 2024: contributorok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated. nvm
-
MarnixCroes closed this on Apr 25, 2024
-
MarnixCroes deleted the branch on Apr 25, 2024
-
laanwj commented at 8:15 am on April 25, 2024: memberRight. i think qt-qml does something substantially different with regard to settings, so it may be warranted there.
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 23:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 23:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me