guiconstants: update ORG_DOMAIN to bitcoincore.org #818

pull MarnixCroes wants to merge 1 commits into bitcoin-core:master from MarnixCroes:ORG_DOMAIN changing 1 files +1 −1
  1. MarnixCroes commented at 7:00 PM on April 24, 2024: contributor

    if desired, can also update ORG_NAME to Bitcoin Core

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. qt/guiconstants: update ORG_DOMAIN to bitcoincore.org 1b7abd2e4e
  3. DrahtBot commented at 7:00 PM on April 24, 2024: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. laanwj commented at 7:31 PM on April 24, 2024: member

    if desired, can also update ORG_NAME to Bitcoin Core

    The reason that this was never done is because it changes where the Qt settings files are stored. For example this is ~/.config/<ORG_NAME>/<APP_NAME> on Linux.

    i'm not sure what actually is the effect of changing the domain, but this shouldn't be done without checking what it is used for.

  5. hebasto commented at 7:49 PM on April 24, 2024: member

    if desired, can also update ORG_NAME to Bitcoin Core

    Are there any issues with the current code? If not, then this PR lacks motivation.

  6. MarnixCroes commented at 12:04 AM on April 25, 2024: contributor

    ok, it came across in the qt-qml repo, I looked here and assumed it was forgotten to be updated. nvm

  7. MarnixCroes closed this on Apr 25, 2024

  8. MarnixCroes deleted the branch on Apr 25, 2024
  9. laanwj commented at 8:15 AM on April 25, 2024: member

    Right. i think qt-qml does something substantially different with regard to settings, so it may be warranted there.

  10. bitcoin-core locked this on Apr 25, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 18:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me