[Design] Privacy mode toggle option 1.0 #82

1. 
   Bosch-0 commented at 7:36 am on September 4, 2020: none

   Below is a design for a comment @promag made here https://github.com/bitcoin/bitcoin/pull/16432#issuecomment-513814481 about having a toggle option for the privacy mode proposed in the same PR.

   Rather than the current user flow of checking/unchecking Menu->Settings->Mask Values users can quickly click the icon to toggle privacy mode on and off resulting in a cleaner flow / less cluttered menu options.

   

   Tooltip - this should not pop up instantly as it does here but rather after a ~750ms delay (same as WindowsOS, which styling this design follows). Figma does not allow an instant delayed animation - it really should.

   

   Why would a user want to have this feature toggled faster?

   A hypothetical scenario would be if the user had the GUI open and someone walked behind them they could quickly conceal their private information by clicking this rather than the current flow which would take a second or two compared to milliseconds clicking the toggle.

   Why V1? Whats next?

   This version stays within the scope of https://github.com/bitcoin/bitcoin/pull/16432 by only concealing information in the overview section of the GUI. Having privacy mode extended to the other menu options (e.g. concealing addresses / transaction hashes in transactions menu) is something that could be explored in a further version of this. The toggle would need to be moved to a global section for this, either in the bottom or top menu.

   Figma source file Icons used (these two icons are not currently in the GUI)

2. Bosch-0 added the label Feature on Sep 4, 2020
3. 
   RandyMcMillan commented at 7:53 am on September 4, 2020: contributor

   Can it be mapped to a key command? That would be great.
4. 
   jonatack commented at 7:54 am on September 4, 2020: contributor

   Concept ACK as long as the keyboard shortcut remains, and perhaps the menu option as well. These, with the local icons, could probably all become global toggles when privacy mode is extended to other pages.
5. 
   jonatack commented at 7:55 am on September 4, 2020: contributor

   Can it be mapped to a key command? That would be great.

   There has been a keyboard shortcut command from the start, which is what many people probably use. I avoid using the mouse (track ball, in my case).

6. 
   jonasschnelli commented at 9:26 am on September 4, 2020: contributor

   Having a quick icon to press would be good. Currently there is the Shift-Command-M shortcut available. Unsure about the icon and its position. We have used the “eye” icon for indicating watch-only transactions/values (kind-off a different function).

7. 
   promag commented at 9:35 am on September 4, 2020: contributor

   It should not be in the overview tab but in the top toolbar. There’s a combo box with the currently opened wallets so I think it could also have more buttons there.
8. 
   ncoelho commented at 10:11 am on September 7, 2020: none

   Concept NACK.

   Adding not strictly necessary UI elements to the main screen is the definition of clutter, this is an edge case, not the main use case. In this exemple in terms of information architecture we now have the hidden option with a bigger visual weight clue as the wallet balance itself, the most important piece of information on this screen.

   Suggestion on how to achieve this interaction without bringing clutter to the UI:

   • Click on the balance, change the balance visible state
   • Hover the balance brings tooltip to hide the balance state
   • keyboard shortcut
9. 
   Sjors commented at 1:33 pm on September 7, 2020: member

   This seems overkill. You can hide the window with Cmd + h. Perhaps a keyboard shortcut to unload the wallet could be added (if it’s not there already). You really shouldn’t be using Bitcoin Core in a place where you wouldn’t be comfortable putting stacks of cash on a table.
10. Bosch-0 renamed this:
    [Design] Privacy mode toggle option V1
    [Design] Privacy mode toggle option 1.0
    on Sep 12, 2020
11. 
    Bosch-0 commented at 9:17 am on September 24, 2020: none

    How about having the icon in the bottom right along with the other icons. I think this is more suitable than including it in the top menu next to wallets.

    

    You really shouldn’t be using Bitcoin Core in a place where you wouldn’t be comfortable putting stacks of cash on a table.

    I completely agree but you can always count on people making bad decisions haha

Contributors
Bosch-0 RandyMcMillan jonatack jonasschnelli promag ncoelho Sjors

Labels
Feature