1. 
   ChillerDragon commented at 10:11 am on June 5, 2024: none

   before

   

   after

   

2. wallet: Improve error log color in the console 23ad3f8d9a
3. 
   DrahtBot commented at 10:11 am on June 5, 2024: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. 
   MarnixCroes commented at 10:32 am on June 5, 2024: contributor

   The default GUI is in light-mode, red looks fine there for me. Other warning messages throughout the GUI are also using red, they should all use the same color.
5. wallet: Use softer reds for errors 341c286da6
6. ChillerDragon force-pushed on Jun 5, 2024
7. 
   ChillerDragon commented at 10:57 am on June 5, 2024: none

   A light theme indeed is smoother on the eye

   

   I still think the softer color is better. And it fits both dark and light themes.

8. 
   katesalazar commented at 5:18 pm on June 7, 2024: contributor

   ~
9. 
   luke-jr commented at 8:28 pm on June 12, 2024: member

   Pink on white probably isn’t a good idea…
10. 
    hebasto commented at 11:41 am on July 15, 2024: member

    cc @GBKS for a designer’s opinion.

    I still think the softer color is better.

    I’m not a designer, but I find the current implementation the most appealing.

    As for implementation, a named constant should be used in the code.

11. 
    GBKS commented at 11:40 am on July 16, 2024: none

    cc @GBKS for a designer’s opinion.

    Personally, I find the new color more pleasant, and it goes better with the teal. It’s a bit too toned down for me, and the old red does a better job at drawing attention and ensuring you look at it, which is appropriate for a scammer warning. I’d probably look at something in-between (strong red, but not jarring), and also tweak the other colors used in the logs so they all go together well and have good contrast on light and dark backgrounds (the teal has weak contrast on black right now). YMMV.

    Just generally, a good practice for design systems is that you use the same color palette throughout the application (e.g. same red(s) everywhere), and fine-tune the colors so they go well with each other (-> you work on the whole system). For light/dark modes, it’s also good to make tweaks (e.g. slightly different red in dark mode than in light mode), since our eyes pick up colors differently based on environment/lighting/…. I don’t know if one of the ambitions is to have a super tight design system throughout the application, so this practice may or may not be relevant.

    Not feeling super strong either way about this PR, feel free to ignore my input.

12. 
    hebasto commented at 10:01 am on July 29, 2024: member

    This PR touches stuff that requires attention from both design and coding perspectives.

    As for designers, they are currently focused on the future Bitcoin Core App design, which is being implemented in https://github.com/bitcoin-core/gui-qml.

    From a coding perspective, I believe that introducing “magic” numbers spread across the code is an inferior implementation compared to using theme-specific palettes or the currently used named constants.

    Therefore, I’m going to close this PR.

13. hebasto closed this on Jul 29, 2024

    ---

Contributors
ChillerDragon DrahtBot MarnixCroes katesalazar luke-jr hebasto GBKS