Remove unused “What’s This” button in dialogs on Windows OS #85

1. 
   hebasto commented at 3:32 pm on September 7, 2020: member

   Fix #74.

   From Qt docs:

   The widget flags f are passed on to the QWidget constructor. If, for example, you don’t want a What’s This button in the title bar of the dialog, pass Qt::WindowTitleHint | Qt::WindowSystemMenuHint in f.

   Screenshot on Windows 10 (2004):

   • master (3ba25e3bdde3464eed5d2743d68546e48b005544)

   • this PR (e322fe7e19ac504272d14b9b4f9b28b13df888ed)

2. 
   MarcoFalke commented at 3:54 pm on September 7, 2020: contributor

   Please split this into two commits, otherwise literally every commit could be a scripted diff by including the diff as a patch in the commit body
3. qt: Add flags to prevent a "What's This" button on Windows OS b6951483ec
4. scripted-diff: Remove unused "What's This" button in dialogs on Windows

   -BEGIN VERIFY SCRIPT-
   git grep -l 'QDialog(parent)' -- src/qt | xargs sed -i -E 's/QDialog\(parent\)/QDialog\(parent, GUIUtil::dialog_flags\)/g'
   -END VERIFY SCRIPT-

   ac7ccd67d7
5. hebasto force-pushed on Sep 7, 2020
6. 
   hebasto commented at 4:13 pm on September 7, 2020: member

   Updated e322fe7e19ac504272d14b9b4f9b28b13df888ed -> ac7ccd67d7f2b09e36dd57405f899e4698dd3d78 (pr85.01 -> pr85.02, diff):

   • addressed @MarcoFalke’s comment:

   Please split this into two commits, otherwise literally every commit could be a scripted diff by including the diff as a patch in the commit body

7. 
   Bosch-0 commented at 6:49 am on October 23, 2020: none

   tACK ac7ccd67d7f2b09e36dd57405f899e4698dd3d78 Tested on Windows 10.0.18363 Build 18363.

   Master (56a461f) vs this PR (ac7ccd6)

   

   This PR also removes this unused dialog button from the following windows on Windows 10 compared to master.

   • About Bitcoin Core
   • Command-line options
   • Request payment modal when generating a new receive address
   • Create Wallet
   • Encrypt wallet when creating a new wallet
   • Signature signing / verifying
   • Open Bitcoin URI
   • Receive addresses
   • Sending addresses
8. 
   luke-jr commented at 7:55 pm on October 24, 2020: member

   Is there a way we can exclude the “What’s This?” button rather than explicitly list included buttons?
9. 
   hebasto commented at 8:10 pm on October 24, 2020: member

   Is there a way we can exclude the “What’s This?” button rather than explicitly list included buttons?

   Qt docs do not provide that way.

10. jonasschnelli added this to the milestone 0.22.0 on Nov 11, 2020
11. in src/qt/sendcoinsdialog.cpp:56 in ac7ccd67d7

    52@@ -53,7 +53,7 @@ int getIndexForConfTarget(int target) {
    53 }
    54 
    55 SendCoinsDialog::SendCoinsDialog(const PlatformStyle *_platformStyle, QWidget *parent) :
    56-    QDialog(parent),
    57+    QDialog(parent, GUIUtil::dialog_flags),
    

    ---

    ---

    

    promag commented at 10:47 pm on November 18, 2020:

    It extends dialog but it’s not used as such. I think you could drop this change?

    ---

    

    hebasto commented at 8:27 pm on November 28, 2020:

    I think you could drop this change?

    Adding widget flags to remove “What’s This” button is the goal of this PR. Or did I understand you in a wrong way?

12. in src/qt/receivecoinsdialog.cpp:25 in ac7ccd67d7

    21@@ -21,7 +22,7 @@
    22 #include <QTextDocument>
    23 
    24 ReceiveCoinsDialog::ReceiveCoinsDialog(const PlatformStyle *_platformStyle, QWidget *parent) :
    25-    QDialog(parent),
    26+    QDialog(parent, GUIUtil::dialog_flags),
    

    ---

    ---

    

    promag commented at 10:47 pm on November 18, 2020:

    Same as SendCoinsDialog.
13. 
    promag commented at 10:50 pm on November 18, 2020: contributor

    Code review ACK ac7ccd67d7f2b09e36dd57405f899e4698dd3d78 but with some suggestions.

    Does it make sense to have a QDialog subclass? There’s also the call handleCloseWindowShortcut.

14. jonasschnelli approved
15. 
    jonasschnelli commented at 9:16 am on January 28, 2021: contributor

    utACK ac7ccd67d7f2b09e36dd57405f899e4698dd3d78
16. jonasschnelli merged this on Jan 28, 2021
17. jonasschnelli closed this on Jan 28, 2021

    ---

18. hebasto deleted the branch on Jan 28, 2021
19. sidhujag referenced this in commit ef9018a66c on Jan 28, 2021
20. 
    hebasto commented at 6:25 am on February 24, 2021: member

    @luke-jr

    Is there a way we can exclude the “What’s This?” button rather than explicitly list included buttons?

    I was wrong.

    The Qt::AA_DisableWindowContextHelpButton application attribute value was added in Qt 5.10.

    Unfortunately, we have minimum Qt version 5.5.1.

21. bitcoin-core locked this on Aug 16, 2022

Contributors
hebasto MarcoFalke Bosch-0 luke-jr promag jonasschnelli

Milestone
22.0