Menu action to export a watchonly wallet #872

1. 
   achow101 commented at 11:31 pm on May 13, 2025: member

   Allows a user to export a watchonly version of their wallet to be used in an airgapped setup.

   Built on https://github.com/bitcoin/bitcoin/pull/32489

2. 
   DrahtBot commented at 11:31 pm on May 13, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin/bitcoin/33135 (wallet: warn against accidental unsafe older() import by Sjors)
   • #bitcoin/bitcoin/33034 (wallet: Store transactions in a separate sqlite table by achow101)
   • #bitcoin/bitcoin/33008 (wallet: support bip388 policy with external signer by Sjors)
   • #bitcoin/bitcoin/32895 (wallet: Prepare for future upgrades by recording versions of last client to open and decrypt by achow101)
   • #bitcoin/bitcoin/32861 (Have createwalletdescriptor auto-detect an unused(KEY) by Sjors)
   • #bitcoin/bitcoin/32489 (wallet: Add exportwatchonlywallet RPC to export a watchonly version of a wallet by achow101)
   • #bitcoin/bitcoin/32471 (wallet/rpc: fix listdescriptors RPC fails to return descriptors with private key information when wallet contains descriptors missing any key by Eunovo)
   • #bitcoin/bitcoin/29136 (wallet: addhdkey RPC to add just keys to wallets via new unused(KEY) descriptor by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. DrahtBot added the label CI failed on May 14, 2025
4. DrahtBot added the label Needs rebase on May 16, 2025
5. achow101 force-pushed on May 16, 2025
6. DrahtBot removed the label Needs rebase on May 16, 2025
7. DrahtBot removed the label CI failed on May 17, 2025
8. DrahtBot added the label Needs rebase on May 19, 2025
9. achow101 force-pushed on May 20, 2025
10. DrahtBot removed the label Needs rebase on May 20, 2025
11. hebasto renamed this:
    gui: Menu action to export a watchonly wallet
    Menu action to export a watchonly wallet
    on May 20, 2025
12. DrahtBot added the label Needs rebase on May 21, 2025
13. achow101 force-pushed on May 21, 2025
14. DrahtBot removed the label Needs rebase on May 21, 2025
15. DrahtBot added the label CI failed on May 21, 2025
16. achow101 force-pushed on Jun 2, 2025
17. DrahtBot removed the label CI failed on Jun 2, 2025
18. achow101 force-pushed on Jun 4, 2025
19. DrahtBot added the label Needs rebase on Jul 1, 2025
20. descriptor: Add CanSelfExpand()

    CanSelfExpand() reports whether a descriptor can be expanded without
    needing any caches or private keys to be provided by the caller of
    Expand().

    a3be2d8745
21. wallet: Use Descriptor::CanSelfExpand() in CanGetAddresses()

    If a descriptor does not need any caches or private keys in order to
    expand, then CanGetAddresses() should return true for that descriptor.

    9317ea0b1c
22. wallet: Write new descriptor's cache in AddWalletDescriptor

    If a new WalletDescriptor is provided to us with a cache, write the
    cache to disk as well.

    4d7aeab150
23. wallet: Move listdescriptors retrieving from RPC to CWallet

    When listdescriptors retrieves the descriptors from the wallet, instead
    of having this logic in the RPC, move it into CWallet itself. This
    will enable other functions to get the descriptors in an exportable
    form.

    67216700ce
24. wallet: Add CWallet::ExportWatchOnly

    ExportWatchOnly produces a watchonly wallet file from a CWallet. This
    can be restored onto another instance of Bitcoin Core to allow that
    instance to watch the same descriptors, and also have all of the same
    initial address book and transactions.

    2e833c1ea7
25. wallet, rpc: Add exportwatchonlywallet RPC 7775c549f6
26. test: Test for exportwatchonlywallet 6e8cddbd30
27. doc: update offline-signing-tutorial to use exportwatchonlywallet rpc 0f54714148
28. gui: Menu action for exporting a watchonly wallet 22f3717d3c
29. achow101 force-pushed on Sep 11, 2025
30. DrahtBot removed the label Needs rebase on Sep 11, 2025

Contributors
achow101 DrahtBot