New SVG, Icons, PNGs and X PixMaps #879
pull 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw wants to merge 1 commits into bitcoin-core:master from 1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw:master changing 15 files +1294 −1448-
1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw commented at 3:38 pm on July 10, 2025: noneThis PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.
-
New SVG, Icons, PNGs and X PixMaps
This PR clean up the old SVG, Icons, PNGs and X PixMaps by providing optimized much smaller file size versions while at the same time keeping resolutions untouched. Shadows are removed from the files.
-
DrahtBot commented at 3:38 pm on July 10, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers Concept NACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #852 (Updated MacOS icon to more closely fit Apple’s design standards by rhysbeynon)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
hebasto commented at 3:58 pm on July 10, 2025: member
Shadows are removed from the files.
Why do you think this change is necessary?
Also, the size of the logo has been increased. Could you please mention this in the PR description as well, along with a justification for the change?
-
1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw commented at 4:28 pm on July 10, 2025: none
@hebasto The logo sizes remain unchanged; only the padding have been removed. When compiling Bitcoin Core, everything appears exactly as it did before.
The shadows were removed to match the original Bitcoin logo from bitboy, which also did not include shadows. Since users may download the Bitcoin logo (example the SVG version) directly from Bitcoin Core’s source code, this ensures they receive properly optimized logo files.
-
hebasto commented at 4:39 pm on July 10, 2025: member
GitHub renders chnages as follows:
… only the margins have been removed.
Why?
The shadows were removed to match the original Bitcoin logo from bitboy, which also did not include shadows.
Bitcoin Core has its own logo for years. I don’t see your reference as a justification for this change.
Since users may download the Bitcoin logo (example the SVG version) directly from Bitcoin Core’s source code, this ensures they receive properly optimized logo files.
I believe this constitutes a misuse of the Bitcoin Core codebase.
-
1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw commented at 10:26 pm on July 10, 2025: none
Why?
Padding (not margin) has been removed because it is unnecessary and visually disruptive. Padding serves no purpose and only worsens the layout.
Bitcoin Core has its own logo for years. I don’t see your reference as a justification for this change.
I discussed this PR with @jonasschnelli on IRC a few days ago. As the creator of the original logo files, he understands the rationale behind replacing them.
I believe this constitutes a misuse of the Bitcoin Core codebase.
This assumption is incorrect. Users seeking the Bitcoin logo will specifically want Bitcoin Core’s canonical
bitcoin.svg
file, not alternative versions. -
hebasto commented at 10:59 am on July 11, 2025: member
Why?
Padding (not margin) has been removed because it is unnecessary and visually disruptive. Padding serves no purpose and only worsens the layout.
Not being a designer, these claims seem like a matter of taste to me. It would be helpful to hear other designers’ opinions.
Bitcoin Core has its own logo for years. I don’t see your reference as a justification for this change.
I discussed this PR with @jonasschnelli on IRC a few days ago. As the creator of the original logo files, he understands the rationale behind replacing them.
I have deep respect for @jonasschnelli, but PR discussions should not be based on someone’s personal opinion without supporting reasoning.
I believe this constitutes a misuse of the Bitcoin Core codebase.
This assumption is incorrect. Users seeking the Bitcoin logo will specifically want Bitcoin Core’s canonical
bitcoin.svg
file, not alternative versions.That sounds at least controversial. If that were true, the current logos wouldn’t have been merged in the first place.
-
jonasschnelli commented at 11:18 am on July 11, 2025: contributor
I briefly discussed the issue of copyright and authorship on the SVG with the PR author in #bitcoin (IRC).
It sounded to me that the PR author was worried about the copyright and MIT licensing as well as who was the original designer. Unclear what the intention of this PR is as this also changes the copyright in the file.
I have no opinion on visual style.
-
1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw commented at 3:25 pm on July 11, 2025: none
The copyright notice and MIT license were removed from the SVG file because “Bitboy,” the original designer of the Bitcoin logo, released the work into the public domain. This is further confirmed by Wikimedia Commons, where the Bitcoin logo is explicitly marked as public domain—a fact that has been verified multiple times.
The goal of this PR is not just to correct the licensing information but also to provide optimized logo files for all operating systems, ensuring they use proper Bitcoin logos without unnecessary padding.
By merging this PR, Bitcoin Core will include uniquely optimized files that are not available elsewhere. As seen in the changes, the file sizes have been significantly reduced.
Given that the current files are 12–13 years old, it’s time for an update. This PR delivers the best possible versions, ensuring the logos look flawless after compiling Bitcoin Core.
-
hebasto commented at 3:41 pm on July 11, 2025: member
The goal of this PR is not just to correct the licensing information …
Please update the PR description accordingly.
Given that the current files are 12–13 years old, it’s time for an update.
That’s not a justification for the changes, neither from a technical perspective nor a design one.
NACK from me.
-
fanquake commented at 5:49 pm on July 11, 2025: member@1BitcoinBoWP1FZ4xwTNkq6XksKidmgYYw that kind of commentary is unacceptable.
-
fanquake closed this on Jul 11, 2025
-
bitcoin-core locked this on Jul 11, 2025
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-31 10:20 UTC
More mirrored repositories can be found on mirror.b10c.me