rpcnestedtests.cpp:remove qtest-obsolete members #900
pull RandyMcMillan wants to merge 2 commits into bitcoin-core:master from bitcoincore-dev:1916/918478/320568/41e4011266/29e47ce92d-rpcnestedtests.cpp changing 1 files +19 −24-
RandyMcMillan commented at 7:35 pm on October 10, 2025: contributor
-
src/qt/test/rpcnestedtests.cpp:remove qtest-obsolete members 39d699c9e9
-
src/qt/test/rpcnestedtests.cpp:apply clang-format 4f29ddf3c5
-
DrahtBot commented at 7:35 pm on October 10, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #bitcoin/bitcoin/33214 (rpc: require integer verbosity; remove boolean ‘verbose’ by fqlx)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
RandyMcMillan commented at 7:42 pm on October 10, 2025: contributorI will remove 4f29ddf3c5cbd373ebbfe05e5cd571cc9b383b0c if requested.
-
in src/qt/test/rpcnestedtests.cpp:123 in 39d699c9e9 outdated
118@@ -119,18 +119,13 @@ void RPCNestedTests::rpcNestedTests() 119 RPCConsole::RPCExecuteCommandLine(m_node, result, "rpcNestedTest( abc , cba )"); 120 QVERIFY(result == "[\"abc\",\"cba\"]"); 121 122-// Handle deprecated macro, can be removed once minimum Qt is at least 6.3.0. 123-#if (QT_VERSION >= QT_VERSION_CHECK(6, 3, 0))
hebasto commented at 7:54 pm on October 10, 2025:The minimum supported Qt version remains 6.2 for now.
RandyMcMillan commented at 8:19 pm on October 10, 2025:I couldn’t find where 6.2 was actually being tested against in the CI? Maybe it is a good time to bump the minimum supported version?
RandyMcMillan commented at 8:20 pm on October 10, 2025:6.7 was the earliest I could find?
hebasto commented at 8:49 pm on October 10, 2025:Maybe it is a good time to bump the minimum supported version?
We still support Ubuntu 22.04: https://packages.ubuntu.com/jammy/qt6-base-dev.
RandyMcMillan commented at 10:34 pm on October 10, 2025:note: https://github.com/bitcoin-core/gui/actions/runs/18416608653/job/52481652961
only failure - which suggests the tests aren’t actually testing qt version <= 6.2
RandyMcMillan marked this as a draft on Oct 10, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-18 14:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-18 14:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me