The gui doesn’t handle exceptions very well #91

1. 
   fanquake commented at 8:37 am on September 15, 2020: member

   Moved from https://github.com/bitcoin/bitcoin/issues/18643.

   The GUI crashes on exceptions such as NonFatalCheckError. I think it is more user friendly for a GUI to catch the exception and display it to the user, then abort the current action and leave the main window running.

   I tested this by mutating the conditional in a CHECK_NONFATAL.

    0$ ./src/qt/bitcoin-qt 
    1QSocketNotifier: Can only be used with threads started with QThread
    2
    3
    4************************
    5EXCEPTION: 18NonFatalCheckError       
    6wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
    7Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
    8You may report this issue here: https://github.com/bitcoin/bitcoin/issues
    9       
   10bitcoin in Runaway exception       
   11
   12terminate called after throwing an instance of 'NonFatalCheckError'
   13  what():  wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
   14Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
   15You may report this issue here: https://github.com/bitcoin/bitcoin/issues
   16
   17Aborted (core dumped)
   

   

2. 
   adamjonas commented at 9:38 pm on December 23, 2020: contributor

   Linking to PR https://github.com/bitcoin/bitcoin/pull/18897 which is a possible fix and didn’t make the migration between repos.
3. hebasto added the label Bug on Mar 6, 2021
4. 
   hebasto commented at 6:18 pm on March 26, 2021: member

   Linking to PR bitcoin/bitcoin#18897 which is a possible fix and didn’t make the migration between repos.

   https://github.com/bitcoin/bitcoin/pull/18897 moved to #260.

5. laanwj referenced this in commit 03ecceedf6 on Apr 14, 2021
6. MarcoFalke closed this on Apr 14, 2021

   ---

7. bitcoin-core locked this on Aug 16, 2022

Contributors
fanquake adamjonas hebasto

Labels
Bug