The gui doesn't handle exceptions very well #91

issue fanquake opened this issue on September 15, 2020

fanquake commented at 8:37 AM on September 15, 2020: member

Moved from https://github.com/bitcoin/bitcoin/issues/18643.

The GUI crashes on exceptions such as NonFatalCheckError. I think it is more user friendly for a GUI to catch the exception and display it to the user, then abort the current action and leave the main window running.

I tested this by mutating the conditional in a CHECK_NONFATAL.

$ ./src/qt/bitcoin-qt 
QSocketNotifier: Can only be used with threads started with QThread


************************
EXCEPTION: 18NonFatalCheckError       
wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues
       
bitcoin in Runaway exception       

terminate called after throwing an instance of 'NonFatalCheckError'
  what():  wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
You may report this issue here: https://github.com/bitcoin/bitcoin/issues

Aborted (core dumped)

Screenshot from 2020-04-14 21-11-32

adamjonas commented at 9:38 PM on December 23, 2020: contributor

Linking to PR https://github.com/bitcoin/bitcoin/pull/18897 which is a possible fix and didn't make the migration between repos.
hebasto added the label Bug on Mar 6, 2021
hebasto commented at 6:18 PM on March 26, 2021: member

Linking to PR bitcoin/bitcoin#18897 which is a possible fix and didn't make the migration between repos.

https://github.com/bitcoin/bitcoin/pull/18897 moved to #260.
laanwj referenced this in commit 03ecceedf6 on Apr 14, 2021
MarcoFalke closed this on Apr 14, 2021
bitcoin-core locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#260 Handle exceptions instead of crash