Added test coverage for qt gui#901 console history filter #910
pull waketraindev wants to merge 1 commits into bitcoin-core:master from waketraindev:2025-11-gui-filtered-qt-tests changing 1 files +7 −1-
waketraindev commented at 5:40 pm on November 6, 2025: contributorAdd test coverage for the QT rpc console updated filtered commands in gui#901
-
DrahtBot commented at 5:41 pm on November 6, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK pablomartin4btc, hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #909 (Prevent re-execution of sensitive commands from console history by waketraindev)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
waketraindev marked this as ready for review on Nov 6, 2025
-
in src/qt/test/rpcnestedtests.cpp:1 in 0e9f330bdc outdated
pablomartin4btc commented at 4:50 pm on November 12, 2025:nit: since you are there please update the copyright (
2016-present)…// Copyright (c) 2016-2021 The Bitcoin Core developerspablomartin4btc commented at 4:54 pm on November 12, 2025: contributortACK 0e9f330bdc9435a1ebea229eba58d434b07ab3aawaketraindev force-pushed on Nov 12, 2025waketraindev force-pushed on Nov 12, 2025DrahtBot added the label CI failed on Nov 12, 2025DrahtBot removed the label CI failed on Nov 12, 2025in src/qt/test/rpcnestedtests.cpp:1 in d32cf0aa52
0@@ -1,4 +1,4 @@ 1-// Copyright (c) 2016-2021 The Bitcoin Core developers 2+// Copyright (c) 2016-2025 The Bitcoin Core developers
pablomartin4btc commented at 10:42 pm on November 12, 2025:so we don’t have to update it every time…
0// Copyright (c) 2016-present The Bitcoin Core developers
waketraindev commented at 10:43 pm on November 12, 2025:Ah fixed, didn’t think you meant present literally; sorryqt: Added test coverage for qt gui#901 console history filter 310e4979b3waketraindev force-pushed on Nov 12, 2025pablomartin4btc approvedpablomartin4btc commented at 10:59 pm on November 13, 2025: contributorACK 310e4979b36cbcf1e9e01dd90c14e2e9997343a0hebasto approvedhebasto commented at 11:23 pm on November 18, 2025: memberACK 310e4979b36cbcf1e9e01dd90c14e2e9997343a0, tested on Fedora 42 by reverting 4e352efa2ce756c668664486c99d003eef530e0c.hebasto merged this on Nov 18, 2025hebasto closed this on Nov 18, 2025
waketraindev deleted the branch on Nov 18, 2025waketraindev restored the branch on Nov 18, 2025waketraindev deleted the branch on Nov 19, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-27 22:20 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-27 22:20 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me