Adds non-mempool wallet balance to overview #911

pull ajtowns wants to merge 4 commits into bitcoin-core:master from ajtowns:202511-wallet-unconf-bal-gui changing 18 files +161 −53
  1. ajtowns commented at 1:26 am on November 19, 2025: contributor

    The wallet can contain transactions that are not accepted into the node’s mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.

    Depends on bitcoin/bitcoin#33671

  2. DrahtBot commented at 1:26 am on November 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  3. DrahtBot added the label CI failed on Nov 19, 2025
  4. ajtowns commented at 7:06 am on November 19, 2025: contributor

    To test, start with -datacarriersize=10, and run

    0send '{"data": "4368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73"}' null "unset" 1
    

    from the console. “Non-mempool: ” should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with -datacarriersize=100000 should allow the tx to enter the mempool, and move the amount into the Available balance. (Presumably, do this on -regtest after generating 100 blocks; or perhaps signet after grabbing some funds from a faucet)

  5. wallet: Have GetBalance report used amount directly without two calls 81e763f1e5
  6. wallet: Add separate balance info for non-mempool wallet txs 183921910d
  7. tests: Add test for mempool-invalid wallet tx
    Uses send rpc to create a tx with oversized OP_RETURN output, verifies
    that it doesn't enter the mempool, and that getbalance rpc returns a
    nonmempool value.
    e7200379f3
  8. ajtowns force-pushed on Nov 27, 2025
  9. ajtowns commented at 8:03 am on November 27, 2025: contributor

    Screenshot:

    The negative sign for the non-memool stuff isn’t really very clear, perhaps.

  10. gui: Add non-mempool balance to wallet overview bc85b4a221
  11. ajtowns force-pushed on Nov 27, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-27 22:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me