Fix transactions disable problem #922

pull beati wants to merge 1 commits into bitcoin-core:master from beati:gui-fix-transactions-disable-problem-2 changing 1 files +2 −0
  1. beati commented at 10:50 PM on January 9, 2026: none
    • In bitcoin-qt, there is under Settings the "Mask values" option
    • When a wallet is open and the "Mask values" checkbox is checked, the "Transactions" tab is disabled
    • When no wallet was open and the "Mask values" checkbox was checked and a wallet was opened, the "Transactions" tab was enabled
    • This fix changes this, so that there is always the same behavior
    • The "Transactions" tab is now always disabled when the "Mask values" checkbox is checked
    • This fix is manually tested on the fork
  2. gui fix transactions disable problem 9f8be883f6
  3. DrahtBot commented at 10:50 PM on January 9, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. DrahtBot added the label CI failed on Jan 10, 2026
  5. hebasto removed the label CI failed on Jan 19, 2026
  6. hebasto renamed this:
    gui: fix transactions disable problem
    Fix transactions disable problem
    on Jan 19, 2026
  7. hebasto commented at 4:05 PM on January 19, 2026: member

    Does this PR solve the same issue as #815?

  8. beati commented at 7:19 PM on January 19, 2026: none

    Does this PR solve the same issue as #815?

    Yes, it looks like. But this PR has a different solution.

  9. hebasto commented at 8:03 PM on March 22, 2026: member

    @beati

    Thank you for your contribution!

    Does this PR solve the same issue as #815?

    Yes, it looks like. But this PR has a different solution.

    An alternative approach was recently merged, as there was a consensus among developers regarding the preferred code structure (see #815 (comment) and #815#pullrequestreview-3988216558).

    Because that solution has already landed, I am closing this PR.

  10. hebasto closed this on Mar 22, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-27 21:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me