qt: Add “Hide conflicted” checkbox to Transactions tab #925

pull w0xlt wants to merge 1 commits into bitcoin-core:master from w0xlt:hide_conflicted changing 2 files +12 −0
  1. w0xlt commented at 7:55 am on February 1, 2026: contributor

    Conflicted transactions can accumulate in the wallet over time. These transactions clutter the transaction list and cannot be filtered out.

    While the Overview page already hides conflicted transactions using TransactionFilterProxy::setShowInactive(false), the Transactions tab has no equivalent option, forcing users to scroll through potentially many obsolete entries.

    This PR adds a “Hide conflicted” checkbox to the Transactions tab filter row, allowing users to toggle visibility of conflicted transactions. The implementation reuses the existing setShowInactive() function.

    Before: Users must manually scroll past conflicted transactions with no filtering option.

    After: A checkbox in the filter row lets users hide conflicted transactions with one click.

  2. qt: Add checkbox to hide conflicted transactions
    Add a "Hide conflicted" checkbox to the Transactions tab filter row,
    allowing users to hide conflicted transactions from the transaction list.
    This reuses the existing TransactionFilterProxy::setShowInactive()
    functionality that was already used by the Overview page.
    1f9396f6e5
  3. DrahtBot commented at 7:55 am on February 1, 2026: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept ACK pablomartin4btc
    Approach NACK luke-jr

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  4. DrahtBot added the label CI failed on Feb 1, 2026
  5. luke-jr commented at 5:46 pm on February 2, 2026: member
    Approach NACK. “Conflicted” should be reduced to an implementation detail IMO. Instead, I suggest hiding conflicted transactions by default after N blocks, and have an advanced setting (in the settings dialog?) to show them.
  6. pablomartin4btc commented at 6:26 pm on February 7, 2026: contributor

    Concept ACK

    One thought: perhaps the Hide button should only appear when there are actually conflicted transactions present.

    Alternatively, if Luke’s approach is preferred, it might be worth adding some visual indication (e.g. a label or status message) that conflicted transactions exist, or enabling a button/action to view them in a separate window.

    Finally, if feasible, it would be great to include brief test instructions in the PR description, outlining how to verify the behavior before and after the change.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/gui. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-19 00:20 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me