Fix issues with new create wallet dialogue #934

1. 
   sbddesign commented at 11:34 pm on March 25, 2026: none

   With this PR, I aim to fix #151.

   As @Rspigler noted in the issue:

   1. When creating a new wallet, the UI offers an option to “encrypt wallet”, which is misleading, because only private keys are encrypted and not other wallet data.
   2. There are issues with the options for Disable Private Keys and Make Blank Wallet being disabled/enabled in ways that don’t make sense.

   Point number one is still an issue. However, as @vasild mentioned here, point number 2 is no longer happening as of 17072f7. They point out another inconsistency where:

   • User chooses “Encrypt Wallet”
     • This disables “Disable Private Keys” in an unchecked state
   • User chooses “Make Blank Wallet”
   • Uses unchecks “Make Blank Wallet”
     • This enables “Disable Private Keys”, allowing it to be checked

   This PR fixes @Rspigler’s point number one by changing the “Encrypt Wallet” tooltip to clarify that it encrypts the private key rather than the wallet. It also fixes @vasild’s noted inconsistency where the checkbox becomes re-enabled.

   Rationale

   I considered for a moment that it might be more technically accurately to say “encrypt private key” instead of “encrypt wallet”. However, I counted 27 instances of user-facing strings that describe encrypting the wallet. Users might be accustomed to the feature being called “encrypt wallet”, so changing the text all across the app felt drastic, IMHO. Therefore, I thought we could simply provide some clarification in the tooltip that encrypting the wallet specifically means encrypting the private keys, but not other wallet metadata.

   Testing

   I successfully built the application with each commit of this PR, and I ran ctest --test-dir build to verify all the tests passed.

   First PR

   This is my first time opening a PR to Bitcoin Core. I’ve done my research on best practices, but I probably made errors. Happy to correct anything I may have missed.

2. fix encrypt wallet wording

   In the "Create Wallet" UI, there is an option and tooltip for "Encrypt Wallet", which is misleading because only the private key is encrypted. This updates the tooltip text to indicate that only the private key is encrypted.
   
   refs bitcoin-core/gui#151

   9ee73f11d8
3. gui: fix advanced options toggles

   In the "Create Wallet" UI, checking the encrypt wallet option disables the "Disable Private Keys" option. However, checking the encryption option and "Make Blank Wallet" re-enables "Disable Private Keys" incorrectly. This fixes that so it does not re-enable the option.
   
   refs bitcoin-core/gui#151

   778e6eb290
4. 
   DrahtBot commented at 11:34 pm on March 25, 2026: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

5. in src/qt/createwalletdialog.cpp:80 in 778e6eb290

   76@@ -77,7 +77,7 @@ CreateWalletDialog::CreateWalletDialog(QWidget* parent) :
   77     connect(ui->blank_wallet_checkbox, &QCheckBox::toggled, [this](bool checked) {
   78         // Disable the disable_privkeys_checkbox when blank_wallet_checkbox is checked
   79         // as blank-ness only pertains to wallets with private keys.
   80-        ui->disable_privkeys_checkbox->setEnabled(!checked);
   81+        ui->disable_privkeys_checkbox->setEnabled(!checked && !ui->encrypt_wallet_checkbox->isChecked());
   

   ---

   ---

   

   luke-jr commented at 9:51 pm on March 27, 2026:

   Seems like the opposite fix is also needed?

   I feel like this whole logic needs to be rewritten…

6. hebasto renamed this:
   gui: Fix issues with new create wallet dialogue
   Fix issues with new create wallet dialogue
   on Mar 28, 2026

Contributors
sbddesign DrahtBot luke-jr