gui: show wallet name in progress messages #939

What

Include the wallet display name in the initMessage calls made during wallet loading so the splash screen clearly identifies which wallet is being processed:

• LoadWalletInternal: "Loading wallet…" → "[wallet_name] Loading wallet…"
• CreateWallet: "Creating wallet…" → "[wallet_name] Creating wallet…"
• CWallet::AttachChain: "Rescanning…" → "[wallet_name] Rescanning…" (primary fix)

For unnamed (default) wallets, DisplayName() already returns the translated "default wallet" string, handling that case correctly.

A comment is added to LoadWalletsActivity::load() explaining why no specific wallet name is shown there — it loads multiple wallets simultaneously from the node's wallet list.

Why

When a wallet that has not been synchronized recently is opened — either via settings.json at startup or via File > Open Wallet — the splash screen shows a bare "Rescanning…" with no indication of which wallet is being scanned. Users with multiple wallets have no way to know which one is being processed without checking the debug log.

The ShowProgress calls inside ScanForWalletTransactions already use "[wallet_name] Rescanning…" (lines 1888/1903/2008); this change makes the preceding initMessage consistent with them.

Fixes #259

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #bitcoin/bitcoin/30343 (wallet, logging: Replace WalletLogPrintf() with LogInfo() by ryanofsky)
• #bitcoin/bitcoin/25722 (refactor: Use util::Result class for wallet loading by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

Hi @hebasto @fanquake , gentle ping on this one!

Small UX consistency fix, no logic changes, only initMessage call-site text updates across two files.

Problem: when a wallet that hasn't synced recently is opened (via settings.json at startup or File > Open Wallet), the splash screen shows a bare "Rescanning…" with no indication of which wallet is being scanned. Users with multiple wallets have to check the debug log to find out.

Fix: include DisplayName() in three initMessage calls:

• LoadWalletInternal: "Loading wallet…" → "[wallet_name] Loading wallet…"
• CreateWallet: "Creating wallet…" → "[wallet_name] Creating wallet…"
• CWallet::AttachChain: "Rescanning…" → "[wallet_name] Rescanning…" ← primary fix

DisplayName() already returns the translated "default wallet" string for unnamed wallets, so that case is handled correctly without extra logic.

Consistency note: ShowProgress calls inside ScanForWalletTransactions (lines 1888/1903/2008) already use "[wallet_name] Rescanning…" , this change makes the preceding initMessage consistent with them.

Re conflicts with #30343 and #25722: both are drafts and neither has been merged. Happy to rebase once either lands if that helps move things forward.

Fixes #259.