gui: Separate rpcconsole from nodewindow #98

pull RandyMcMillan wants to merge 1 commits into bitcoin-core:master from RandyMcMillan:nodewindow-gui changing 4 files +8 −8

RandyMcMillan commented at 9:33 PM on September 18, 2020: contributor

Separate RCPConsole from Node Window
rename debugwindow.ui to nodewindow.ui 111541e699

in src/qt/forms/nodewindow.ui:9 in 111541e699

   5 | @@ -6,12 +6,12 @@
   6 |     <rect>
   7 |      <x>0</x>
   8 |      <y>0</y>
   9 | -    <width>740</width>
  10 | -    <height>430</height>
  11 | +    <width>777</width>

promag commented at 9:20 PM on September 20, 2020:

Unrelated change.

promag commented at 9:29 PM on September 20, 2020: contributor

Concept -0. File rename was avoided when the title was changed, see https://github.com/bitcoin/bitcoin/pull/17096.
Sjors commented at 2:20 PM on September 21, 2020: member

This change is more suitable for a larger PR that changes something meaningful in node window, see developer notes:

Do not submit patches solely to modify the style of existing code.
RandyMcMillan commented at 3:44 AM on September 22, 2020: contributor

@Sjors - the idea was to move toward restructuring the rpcConsole implementation to a "data_model view controller" type implementation - as it is now the "Node Window" seems too monolithic - the information, console, network traffic and peers tabs should be separated to follow a better design paradigm. I believe this is an impediment to better GUI design.
hebasto commented at 6:33 AM on September 22, 2020: member

@RandyMcMillan

@Sjors - the idea was to move toward restructuring the rpcConsole implementation to a "data_model view controller" type implementation - as it is now the "Node Window" seems too monolithic - the information, console, network traffic and peers tabs should be separated to follow a better design paradigm. I believe this is an impediment to better GUI design.

Nice topic for the Bitcoin Design Community!
promag commented at 6:37 AM on September 22, 2020: contributor

@RandyMcMillan is the file rename a blocker?
Sjors commented at 10:14 AM on September 22, 2020: member

This commit can be part of a PR that actually does the restructuring.
RandyMcMillan renamed this:
~~rename debugwindow.ui to nodewindow.ui~~
gui: Seperate rpcconsole from nodewindow
on Sep 26, 2020
RandyMcMillan closed this on Sep 26, 2020
RandyMcMillan renamed this:
~~gui: Seperate rpcconsole from nodewindow~~
gui: Separate rpcconsole from nodewindow
on Sep 26, 2020
RandyMcMillan commented at 12:09 AM on September 26, 2020: contributor

Implementing the change...thanks for the feed back. I wasn't sure whether to do this change incrementally. More to follow. I will reopen as a draft when it is a little further along.
bitcoin-core locked this on Feb 15, 2022

Contributors