Replace ProxyServer connection pointer with reference #11

1. 
   ryanofsky commented at 9:06 pm on August 19, 2019: collaborator

   This is just cleanup. Using a pointer instead of reference used to be necessary before the Connection constructor took a make_server option. But now there is no reason to have a pointer and unnecessary null handling.

   Also, Connection add_client option and AddClient RemoveClient ServeStream wrapper functions are removed. These were originally meant to simplify usages but cause more trouble than they are worth.

2. Replace ProxyServer connection pointer with reference

   This is just cleanup. Using a pointer instead of reference used to be necessary
   before the Connection constructor took a make_server option. But now there is
   no reason to have a pointer and unnecessary null handling.
   
   Also, Connection add_client option and AddClient RemoveClient ServeStream
   wrapper functions are removed. These were originally meant to simplify usages
   but cause more trouble than they are worth.

   e7687dbed6
3. ryanofsky referenced this in commit 2a2549cea3 on Aug 19, 2019
4. ryanofsky merged this on Aug 19, 2019
5. ryanofsky closed this on Aug 19, 2019

   ---

6. bitcoin-core locked this on Jun 25, 2025

Contributors
ryanofsky