Compiler warnings from capnproto when building via add

ryanofsky commented at 4:15 pm on January 28, 2025: collaborator

Originally posted by @Sjors in https://github.com/bitcoin/bitcoin/pull/31741#pullrequestreview-2577588200

On (M4) macOS 15.2 I get a flood of warnings, which means I can’t use -DWERROR=ON:

 0In file included from /opt/homebrew/include/capnp/common.h:31:
 1/opt/homebrew/include/kj/windows-sanity.h:39:6: warning: '_WIN32' is not defined, evaluates to 0 [-Wundef]
 2   39 | #if !_WIN32 && !__CYGWIN__
 3      |      ^
 4/opt/homebrew/include/kj/windows-sanity.h:39:17: warning: '__CYGWIN__' is not defined, evaluates to 0 [-Wundef]
 5   39 | #if !_WIN32 && !__CYGWIN__
 6      |     
 7
 8/opt/homebrew/include/capnp/common.h:33:5: warning: 'CAPNP_DEBUG_TYPES' is not defined, evaluates to 0 [-Wundef]
 9
10/opt/homebrew/include/capnp/raw-schema.h:26:5: warning: '_MSC_VER' is not defined, evaluates to 0 [-Wundef]
11
12/opt/homebrew/include/kj/async-prelude.h:34:6: warning: 'KJ_NO_EXCEPTIONS' is not defined, evaluates to 0 [-Wundef]

ryanofsky commented at 4:23 pm on January 28, 2025: collaborator

Using https://github.com/bitcoin/bitcoin/pull/31741 (https://github.com/ryanofsky/bitcoin/commits/pr/subtree.3) I don’t see any warnings on my sstem, so help to provide more steps to reproduce.

If you can try building with make -C build VERBOSE=1 ... that would also help show the compiler comment lines so we can see if there’s something wrong with -I -isystem -Wno-system-headers options that are being passed might be causing this issue.

Sjors commented at 5:30 pm on January 28, 2025: member

On 93ba80b3d78fa1c4e7f614df6517b9cb492d05d7 (build directory deleted)

macOS 15.2 with Xcode 16.2

0cmake -B build -DWERROR=OFF -DBUILD_MULTIPROCESS=ON

  0-- The CXX compiler identification is AppleClang 16.0.0.16000026
  1-- Detecting CXX compiler ABI info
  2-- Detecting CXX compiler ABI info - done
  3-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
  4-- Detecting CXX compile features
  5-- Detecting CXX compile features - done
  6-- Found SQLite3: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2.sdk/usr/include (found suitable version "3.43.2", minimum required is "3.7.17")
  7-- Performing Test CXX_SUPPORTS__WERROR
  8-- Performing Test CXX_SUPPORTS__WERROR - Success
  9-- Setting build type to "RelWithDebInfo" as none was specified
 10-- Performing Test CXX_SUPPORTS__G3
 11-- Performing Test CXX_SUPPORTS__G3 - Success
 12-- Performing Test LINKER_SUPPORTS__G3
 13-- Performing Test LINKER_SUPPORTS__G3 - Success
 14-- Performing Test CXX_SUPPORTS__FTRAPV
 15-- Performing Test CXX_SUPPORTS__FTRAPV - Success
 16-- Performing Test LINKER_SUPPORTS__FTRAPV
 17-- Performing Test LINKER_SUPPORTS__FTRAPV - Success
 18-- Performing Test LINKER_SUPPORTS__WL__FATAL_WARNINGS
 19-- Performing Test LINKER_SUPPORTS__WL__FATAL_WARNINGS - Success
 20-- Performing Test LINKER_SUPPORTS__WL__DEAD_STRIP
 21-- Performing Test LINKER_SUPPORTS__WL__DEAD_STRIP - Success
 22-- Performing Test LINKER_SUPPORTS__WL__DEAD_STRIP_DYLIBS
 23-- Performing Test LINKER_SUPPORTS__WL__DEAD_STRIP_DYLIBS - Success
 24-- Performing Test LINKER_SUPPORTS__WL__HEADERPAD_MAX_INSTALL_NAMES
 25-- Performing Test LINKER_SUPPORTS__WL__HEADERPAD_MAX_INSTALL_NAMES - Success
 26-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
 27-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
 28-- Found Threads: TRUE
 29-- Found Boost: /opt/homebrew/include (found suitable version "1.87.0", minimum required is "1.73.0")
 30-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE
 31-- Performing Test NO_DIAGNOSTICS_BOOST_NO_CXX98_FUNCTION_BASE - Failed
 32-- Found PkgConfig: /opt/homebrew/bin/pkg-config (found version "2.3.0")
 33-- Found Libevent: /opt/homebrew/Cellar/libevent/2.1.12_1/lib (found suitable version "2.1.12-stable", minimum required is "2.1.8")
 34-- Performing Test HAVE_EVHTTP_CONNECTION_GET_PEER_CONST_CHAR
 35-- Performing Test HAVE_EVHTTP_CONNECTION_GET_PEER_CONST_CHAR - Failed
 36-- Looking for C++ include sys/prctl.h
 37-- Looking for C++ include sys/prctl.h - not found
 38-- Looking for C++ include sys/resources.h
 39-- Looking for C++ include sys/resources.h - not found
 40-- Looking for C++ include sys/vmmeter.h
 41-- Looking for C++ include sys/vmmeter.h - found
 42-- Looking for C++ include vm/vm_param.h
 43-- Looking for C++ include vm/vm_param.h - not found
 44-- Looking for O_CLOEXEC
 45-- Looking for O_CLOEXEC - found
 46-- Looking for fdatasync
 47-- Looking for fdatasync - not found
 48-- Looking for fork
 49-- Looking for fork - found
 50-- Looking for pipe2
 51-- Looking for pipe2 - not found
 52-- Looking for setsid
 53-- Looking for setsid - found
 54-- Looking for C++ include sys/types.h
 55-- Looking for C++ include sys/types.h - found
 56-- Looking for C++ include ifaddrs.h
 57-- Looking for C++ include ifaddrs.h - found
 58-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET
 59-- Performing Test IFADDR_LINKS_WITHOUT_LIBSOCKET - Success
 60-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC
 61-- Performing Test STD_ATOMIC_LINKS_WITHOUT_LIBATOMIC - Success
 62-- Looking for std::system
 63-- Looking for std::system - found
 64-- Looking for ::_wsystem
 65-- Looking for ::_wsystem - not found
 66-- Performing Test STRERROR_R_CHAR_P
 67-- Performing Test STRERROR_R_CHAR_P - Failed
 68-- Looking for malloc_info
 69-- Looking for malloc_info - not found
 70-- Performing Test HAVE_MALLOPT_ARENA_MAX
 71-- Performing Test HAVE_MALLOPT_ARENA_MAX - Failed
 72-- Performing Test HAVE_POSIX_FALLOCATE
 73-- Performing Test HAVE_POSIX_FALLOCATE - Failed
 74-- Performing Test HAVE_STRONG_GETAUXVAL
 75-- Performing Test HAVE_STRONG_GETAUXVAL - Failed
 76-- Performing Test HAVE_SOCKADDR_UN
 77-- Performing Test HAVE_SOCKADDR_UN - Success
 78-- Performing Test HAVE_GETRANDOM
 79-- Performing Test HAVE_GETRANDOM - Failed
 80-- Performing Test HAVE_GETENTROPY_RAND
 81-- Performing Test HAVE_GETENTROPY_RAND - Success
 82-- Performing Test HAVE_SYSCTL
 83-- Performing Test HAVE_SYSCTL - Success
 84-- Performing Test HAVE_SYSCTL_ARND
 85-- Performing Test HAVE_SYSCTL_ARND - Failed
 86-- Performing Test HAVE_SSE41
 87-- Performing Test HAVE_SSE41 - Failed
 88-- Performing Test HAVE_AVX2
 89-- Performing Test HAVE_AVX2 - Failed
 90-- Performing Test HAVE_X86_SHANI
 91-- Performing Test HAVE_X86_SHANI - Failed
 92-- Performing Test HAVE_ARM_SHANI
 93-- Performing Test HAVE_ARM_SHANI - Success
 94-- Performing Test CXX_SUPPORTS__WALL
 95-- Performing Test CXX_SUPPORTS__WALL - Success
 96-- Performing Test CXX_SUPPORTS__WEXTRA
 97-- Performing Test CXX_SUPPORTS__WEXTRA - Success
 98-- Performing Test CXX_SUPPORTS__WGNU
 99-- Performing Test CXX_SUPPORTS__WGNU - Success
100-- Performing Test CXX_SUPPORTS__WFORMAT__WFORMAT_SECURITY
101-- Performing Test CXX_SUPPORTS__WFORMAT__WFORMAT_SECURITY - Success
102-- Performing Test CXX_SUPPORTS__WVLA
103-- Performing Test CXX_SUPPORTS__WVLA - Success
104-- Performing Test CXX_SUPPORTS__WSHADOW_FIELD
105-- Performing Test CXX_SUPPORTS__WSHADOW_FIELD - Success
106-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY
107-- Performing Test CXX_SUPPORTS__WTHREAD_SAFETY - Success
108-- Performing Test CXX_SUPPORTS__WLOOP_ANALYSIS
109-- Performing Test CXX_SUPPORTS__WLOOP_ANALYSIS - Success
110-- Performing Test CXX_SUPPORTS__WREDUNDANT_DECLS
111-- Performing Test CXX_SUPPORTS__WREDUNDANT_DECLS - Success
112-- Performing Test CXX_SUPPORTS__WUNUSED_MEMBER_FUNCTION
113-- Performing Test CXX_SUPPORTS__WUNUSED_MEMBER_FUNCTION - Success
114-- Performing Test CXX_SUPPORTS__WDATE_TIME
115-- Performing Test CXX_SUPPORTS__WDATE_TIME - Success
116-- Performing Test CXX_SUPPORTS__WCONDITIONAL_UNINITIALIZED
117-- Performing Test CXX_SUPPORTS__WCONDITIONAL_UNINITIALIZED - Success
118-- Performing Test CXX_SUPPORTS__WDUPLICATED_BRANCHES
119-- Performing Test CXX_SUPPORTS__WDUPLICATED_BRANCHES - Failed
120-- Performing Test CXX_SUPPORTS__WDUPLICATED_COND
121-- Performing Test CXX_SUPPORTS__WDUPLICATED_COND - Failed
122-- Performing Test CXX_SUPPORTS__WLOGICAL_OP
123-- Performing Test CXX_SUPPORTS__WLOGICAL_OP - Failed
124-- Performing Test CXX_SUPPORTS__WOVERLOADED_VIRTUAL
125-- Performing Test CXX_SUPPORTS__WOVERLOADED_VIRTUAL - Success
126-- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE
127-- Performing Test CXX_SUPPORTS__WSUGGEST_OVERRIDE - Success
128-- Performing Test CXX_SUPPORTS__WIMPLICIT_FALLTHROUGH
129-- Performing Test CXX_SUPPORTS__WIMPLICIT_FALLTHROUGH - Success
130-- Performing Test CXX_SUPPORTS__WUNREACHABLE_CODE
131-- Performing Test CXX_SUPPORTS__WUNREACHABLE_CODE - Success
132-- Performing Test CXX_SUPPORTS__WDOCUMENTATION
133-- Performing Test CXX_SUPPORTS__WDOCUMENTATION - Success
134-- Performing Test CXX_SUPPORTS__WSELF_ASSIGN
135-- Performing Test CXX_SUPPORTS__WSELF_ASSIGN - Success
136-- Performing Test CXX_SUPPORTS__WBIDI_CHARS_ANY
137-- Performing Test CXX_SUPPORTS__WBIDI_CHARS_ANY - Failed
138-- Performing Test CXX_SUPPORTS__WUNDEF
139-- Performing Test CXX_SUPPORTS__WUNDEF - Success
140-- Performing Test CXX_SUPPORTS__WUNUSED_PARAMETER
141-- Performing Test CXX_SUPPORTS__WUNUSED_PARAMETER - Success
142-- Performing Test CXX_SUPPORTS__FNO_EXTENDED_IDENTIFIERS
143-- Performing Test CXX_SUPPORTS__FNO_EXTENDED_IDENTIFIERS - Failed
144-- Performing Test CXX_SUPPORTS__FDEBUG_PREFIX_MAP_A_B
145-- Performing Test CXX_SUPPORTS__FDEBUG_PREFIX_MAP_A_B - Success
146-- Performing Test CXX_SUPPORTS__FMACRO_PREFIX_MAP_A_B
147-- Performing Test CXX_SUPPORTS__FMACRO_PREFIX_MAP_A_B - Success
148-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE
149-- Performing Test CXX_SUPPORTS__FSTACK_REUSE_NONE - Failed
150-- Performing Test CXX_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_cc10
151-- Performing Test CXX_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_cc10 - Success
152-- Performing Test LINKER_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_cc10
153-- Performing Test LINKER_SUPPORTS__U_FORTIFY_SOURCE__D_FORTIFY_SOURCE_3_cc10 - Success
154-- Performing Test CXX_SUPPORTS__WSTACK_PROTECTOR
155-- Performing Test CXX_SUPPORTS__WSTACK_PROTECTOR - Success
156-- Performing Test CXX_SUPPORTS__FSTACK_PROTECTOR_ALL
157-- Performing Test CXX_SUPPORTS__FSTACK_PROTECTOR_ALL - Success
158-- Performing Test LINKER_SUPPORTS__FSTACK_PROTECTOR_ALL
159-- Performing Test LINKER_SUPPORTS__FSTACK_PROTECTOR_ALL - Success
160-- Performing Test CXX_SUPPORTS__FCF_PROTECTION_FULL
161-- Performing Test CXX_SUPPORTS__FCF_PROTECTION_FULL - Failed
162-- Performing Test CXX_SUPPORTS__FSTACK_CLASH_PROTECTION
163-- Performing Test CXX_SUPPORTS__FSTACK_CLASH_PROTECTION - Failed
164-- Performing Test CXX_SUPPORTS__MBRANCH_PROTECTION_BTI
165-- Performing Test CXX_SUPPORTS__MBRANCH_PROTECTION_BTI - Success
166-- Performing Test LINKER_SUPPORTS__WL___ENABLE_RELOC_SECTION
167-- Performing Test LINKER_SUPPORTS__WL___ENABLE_RELOC_SECTION - Failed
168-- Performing Test LINKER_SUPPORTS__WL___DYNAMICBASE
169-- Performing Test LINKER_SUPPORTS__WL___DYNAMICBASE - Failed
170-- Performing Test LINKER_SUPPORTS__WL___NXCOMPAT
171-- Performing Test LINKER_SUPPORTS__WL___NXCOMPAT - Failed
172-- Performing Test LINKER_SUPPORTS__WL___HIGH_ENTROPY_VA
173-- Performing Test LINKER_SUPPORTS__WL___HIGH_ENTROPY_VA - Failed
174-- Performing Test LINKER_SUPPORTS__WL__Z_RELRO
175-- Performing Test LINKER_SUPPORTS__WL__Z_RELRO - Failed
176-- Performing Test LINKER_SUPPORTS__WL__Z_NOW
177-- Performing Test LINKER_SUPPORTS__WL__Z_NOW - Failed
178-- Performing Test LINKER_SUPPORTS__WL__Z_SEPARATE_CODE
179-- Performing Test LINKER_SUPPORTS__WL__Z_SEPARATE_CODE - Failed
180-- Performing Test LINKER_SUPPORTS__WL__FIXUP_CHAINS
181-- Performing Test LINKER_SUPPORTS__WL__FIXUP_CHAINS - Success
182-- Found Python3: /opt/homebrew/Frameworks/Python.framework/Versions/3.13/bin/python3.13 (found suitable version "3.13.1", minimum required is "3.10") found components: Interpreter
183-- Found Doxygen: /opt/homebrew/bin/doxygen (found version "1.13.2") found components: doxygen dot
184-- Performing Test HAVE_BUILTIN_PREFETCH
185-- Performing Test HAVE_BUILTIN_PREFETCH - Success
186-- Performing Test HAVE_MM_PREFETCH
187-- Performing Test HAVE_MM_PREFETCH - Failed
188-- Performing Test HAVE_SSE42
189-- Performing Test HAVE_SSE42 - Failed
190-- Performing Test HAVE_ARM64_CRC32C
191-- Performing Test HAVE_ARM64_CRC32C - Success
192-- Looking for F_FULLFSYNC
193-- Looking for F_FULLFSYNC - found
194-- Performing Test HAVE_CLMUL
195-- Performing Test HAVE_CLMUL - Failed
196CMake Deprecation Warning at src/ipc/libmultiprocess/CMakeLists.txt:5 (cmake_minimum_required):
197  Compatibility with CMake < 3.10 will be removed from a future version of
198  CMake.
199
200  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
201  to tell CMake that the project requires at least <min> but has been updated
202  to work with policies introduced by <max> or earlier.
203
204
205-- Found ZLIB: /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2.sdk/usr/lib/libz.tbd (found version "1.2.12")
206-- Performing Test HAVE_PTHREAD_GETNAME_NP
207-- Performing Test HAVE_PTHREAD_GETNAME_NP - Success
208-- Performing Test HAVE_PTHREAD_THREADID_NP
209-- Performing Test HAVE_PTHREAD_THREADID_NP - Success
210-- Performing Test HAVE_PTHREAD_GETTHREADID_NP
211-- Performing Test HAVE_PTHREAD_GETTHREADID_NP - Failed
212
213Configuring secp256k1 subtree...
214-- The C compiler identification is AppleClang 16.0.0.16000026
215-- Detecting C compiler ABI info
216-- Detecting C compiler ABI info - done
217-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
218-- Detecting C compile features
219-- Detecting C compile features - done
220-- Performing Test HAVE_X86_64_ASM
221-- Performing Test HAVE_X86_64_ASM - Failed
222-- Could NOT find Valgrind (missing: Valgrind_INCLUDE_DIR Valgrind_WORKS) 
223-- Performing Test C_SUPPORTS__PEDANTIC
224-- Performing Test C_SUPPORTS__PEDANTIC - Success
225-- Performing Test C_SUPPORTS__WALL
226-- Performing Test C_SUPPORTS__WALL - Success
227-- Performing Test C_SUPPORTS__WCAST_ALIGN
228-- Performing Test C_SUPPORTS__WCAST_ALIGN - Success
229-- Performing Test C_SUPPORTS__WCAST_ALIGN_STRICT
230-- Performing Test C_SUPPORTS__WCAST_ALIGN_STRICT - Failed
231-- Performing Test C_SUPPORTS__WCONDITIONAL_UNINITIALIZED
232-- Performing Test C_SUPPORTS__WCONDITIONAL_UNINITIALIZED - Success
233-- Performing Test C_SUPPORTS__WEXTRA
234-- Performing Test C_SUPPORTS__WEXTRA - Success
235-- Performing Test C_SUPPORTS__WNESTED_EXTERNS
236-- Performing Test C_SUPPORTS__WNESTED_EXTERNS - Success
237-- Performing Test C_SUPPORTS__WNO_LONG_LONG
238-- Performing Test C_SUPPORTS__WNO_LONG_LONG - Success
239-- Performing Test C_SUPPORTS__WNO_OVERLENGTH_STRINGS
240-- Performing Test C_SUPPORTS__WNO_OVERLENGTH_STRINGS - Success
241-- Performing Test C_SUPPORTS__WNO_UNUSED_FUNCTION
242-- Performing Test C_SUPPORTS__WNO_UNUSED_FUNCTION - Success
243-- Performing Test C_SUPPORTS__WRESERVED_IDENTIFIER
244-- Performing Test C_SUPPORTS__WRESERVED_IDENTIFIER - Success
245-- Performing Test C_SUPPORTS__WSHADOW
246-- Performing Test C_SUPPORTS__WSHADOW - Success
247-- Performing Test C_SUPPORTS__WSTRICT_PROTOTYPES
248-- Performing Test C_SUPPORTS__WSTRICT_PROTOTYPES - Success
249-- Performing Test C_SUPPORTS__WUNDEF
250-- Performing Test C_SUPPORTS__WUNDEF - Success
251
252
253secp256k1 configure summary
254===========================
255Build artifacts:
256  library type ........................ Static
257Optional modules:
258  ECDH ................................ OFF
259  ECDSA pubkey recovery ............... ON
260  extrakeys ........................... ON
261  schnorrsig .......................... ON
262  musig ............................... OFF
263  ElligatorSwift ...................... ON
264Parameters:
265  ecmult window size .................. 15
266  ecmult gen table size ............... 86 KiB
267Optional features:
268  assembly ............................ OFF
269  external callbacks .................. OFF
270Optional binaries:
271  benchmark ........................... OFF
272  noverify_tests ...................... ON
273  tests ............................... ON
274  exhaustive tests .................... ON
275  ctime_tests ......................... OFF
276  examples ............................ OFF
277
278Cross compiling ....................... FALSE
279Valgrind .............................. OFF
280Preprocessor defined macros ........... ENABLE_MODULE_ELLSWIFT=1 ENABLE_MODULE_SCHNORRSIG=1 ENABLE_MODULE_EXTRAKEYS=1 ENABLE_MODULE_RECOVERY=1 ECMULT_WINDOW_SIZE=15 COMB_BLOCKS=43 COMB_TEETH=6
281C compiler ............................ AppleClang 16.0.0.16000026, /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
282CFLAGS ................................ 
283Compile options ....................... -pedantic -Wall -Wcast-align -Wconditional-uninitialized -Wextra -Wnested-externs -Wno-long-long -Wno-overlength-strings -Wno-unused-function -Wreserved-identifier -Wshadow -Wstrict-prototypes -Wundef
284Build type:
285 - CMAKE_BUILD_TYPE ................... RelWithDebInfo
286 - CFLAGS ............................. -O2 -g 
287 - LDFLAGS for executables ............ 
288 - LDFLAGS for shared libraries ....... 
289
290
291
292Configure summary
293=================
294Executables:
295  bitcoind ............................ ON
296  bitcoin-node (multiprocess) ......... ON
297  bitcoin-qt (GUI) .................... OFF
298  bitcoin-gui (GUI, multiprocess) ..... OFF
299  bitcoin-cli ......................... ON
300  bitcoin-tx .......................... ON
301  bitcoin-util ........................ ON
302  bitcoin-wallet ...................... ON
303  bitcoin-chainstate (experimental) ... OFF
304  libbitcoinkernel (experimental) ..... OFF
305Optional features:
306  wallet support ...................... ON
307   - descriptor wallets (SQLite) ...... ON
308   - legacy wallets (Berkeley DB) ..... OFF
309  external signer ..................... ON
310  ZeroMQ .............................. OFF
311  USDT tracing ........................ OFF
312  QR code (GUI) ....................... OFF
313  DBus (GUI, Linux only) .............. OFF
314Tests:
315  test_bitcoin ........................ ON
316  test_bitcoin-qt ..................... OFF
317  bench_bitcoin ....................... OFF
318  fuzz binary ......................... OFF
319
320Cross compiling ....................... FALSE
321C++ compiler .......................... AppleClang 16.0.0.16000026, /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++
322CMAKE_BUILD_TYPE ...................... RelWithDebInfo
323Preprocessor defined macros ........... OBJC_OLD_DISPATCH_PROTOTYPES=0
324C++ compiler flags .................... -O2 -g -std=c++20 -fPIC -fdebug-prefix-map=/Users/sjors/dev/bitcoin/src=. -fmacro-prefix-map=/Users/sjors/dev/bitcoin/src=. -Wall -Wextra -Wgnu -Wformat -Wformat-security -Wvla -Wshadow-field -Wthread-safety -Wloop-analysis -Wredundant-decls -Wunused-member-function -Wdate-time -Wconditional-uninitialized -Woverloaded-virtual -Wsuggest-override -Wimplicit-fallthrough -Wunreachable-code -Wdocumentation -Wself-assign -Wundef -Wno-unused-parameter -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -Wstack-protector -fstack-protector-all -mbranch-protection=bti
325Linker flags .......................... -O2 -g -Wl,-dead_strip -Wl,-dead_strip_dylibs -Wl,-headerpad_max_install_names -fstack-protector-all -Wl,-fixup_chains -fPIE -Xlinker -pie
326
327NOTE: The summary above may not exactly match the final applied build flags
328      if any additional CMAKE_* or environment variables have been modified.
329      To see the exact flags applied, build with the --verbose option.
330
331Attempt to harden executables ......... ON
332Treat compiler warnings as errors ..... OFF
333Use ccache for compiling .............. ON
334
335
336-- Configuring done (8.9s)
337-- Generating done (0.2s)
338-- Build files have been written to: /Users/sjors/dev/bitcoin/build

0cmake --build build -j 15 --verbose

That’s so verbose it doesn’t fit in a comment :-)

https://gist.githubusercontent.com/Sjors/2307c73a2db59ca802f5c32d73d175d1/raw/52766be20a47be34447e9bfb87e86d5780e541ed/gistfile1.txt

Sjors commented at 8:02 am on January 30, 2025: member

Happens on CI too: https://github.com/bitcoin/bitcoin/actions/runs/13037449380/job/36371318715?pr=30975

ryanofsky commented at 3:11 pm on January 30, 2025: collaborator

@hebasto do you have any ideas on how to fix these warning: 'XXXXX' is not defined, evaluates to 0 [-Wundef] errors?

I know in the old build system we had a SUPPRESS_WARNINGS workaround for this that used -isystem instead of -I to avoid them: 79e197b from https://github.com/bitcoin/bitcoin/pull/29876

But I can’t find an equivalent workaround in the cmake build. I would expect -Wundef problem didn’t disappear so we much be working around it somehow?

TheCharlatan commented at 3:21 pm on January 30, 2025: collaborator

Shouldn’t these be wrapped in defined(...)?

ryanofsky commented at 3:25 pm on January 30, 2025: collaborator

Shouldn’t these be wrapped in defined(...)?

These warnings are coming from capnproto. I think in most projects using #if UNDEFINED_SYMBOL is very common and using -Wundef is more rare, and in general we shouldn’t be enforcing warnings in external headers.

ryanofsky commented at 3:27 pm on January 30, 2025: collaborator

Not to mention that if defined(SYMBOL) can cause problems because -DSYMBOL=0 will not work.

ryanofsky commented at 4:07 pm on January 30, 2025: collaborator

I feel like I’m pretty stuck here. I’ve been trying to make a similar failure happen on my system, but not getting anywhere. I think maybe following changes would be more correct and might get rid of the errors from boost and capnproto here, but this is a bit of a shot in the dark:

 0--- a/src/ipc/libmultiprocess/CMakeLists.txt
 1+++ b/src/ipc/libmultiprocess/CMakeLists.txt
 2@@ -93,10 +93,10 @@ target_include_directories(multiprocess PUBLIC
 3   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
 4   $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 5   ${CAPNP_INCLUDE_DIRECTORY})
 6-target_link_libraries(multiprocess PRIVATE CapnProto::capnp)
 7-target_link_libraries(multiprocess PRIVATE CapnProto::capnp-rpc)
 8-target_link_libraries(multiprocess PRIVATE CapnProto::kj)
 9-target_link_libraries(multiprocess PRIVATE CapnProto::kj-async)
10+target_link_libraries(multiprocess PUBLIC CapnProto::capnp)
11+target_link_libraries(multiprocess PUBLIC CapnProto::capnp-rpc)
12+target_link_libraries(multiprocess PUBLIC CapnProto::kj)
13+target_link_libraries(multiprocess PUBLIC CapnProto::kj-async)
14 set_target_properties(multiprocess PROPERTIES
15     PUBLIC_HEADER "${MP_PUBLIC_HEADERS}")
16 install(TARGETS multiprocess EXPORT LibTargets
17--- a/src/test/CMakeLists.txt
18+++ b/src/test/CMakeLists.txt
19@@ -164,6 +164,7 @@ endif()
20 if(BUILD_MULTIPROCESS)
21   target_link_libraries(bitcoin_ipc_test
22     PRIVATE
23+      Boost::headers
24       core_interface
25       univalue
26   )

Sjors commented at 4:23 pm on January 30, 2025: member

I’ll give them a try, waiting for the Windows job on the last push: https://github.com/bitcoin/bitcoin/actions/runs/13054985470/job/36423710000?pr=30975

(actually there’s no use in waiting for Windows with multiprocess)

Sjors referenced this in commit f3f4685bc4 on Jan 30, 2025

ryanofsky commented at 11:18 am on January 31, 2025: collaborator

The diff suggested in https://github.com/chaincodelabs/libmultiprocess/issues/138#issuecomment-2624919124 did seem to successfully fix the header warnings in the macos 14 native job here: https://github.com/bitcoin/bitcoin/pull/30975#issuecomment-2625235833

ryanofsky referenced this in commit 434fcb859b on Feb 3, 2025

ryanofsky referenced this in commit 65c7048251 on Feb 3, 2025

ryanofsky closed this on Feb 3, 2025

ryanofsky referenced this in commit 3d83c7aef1 on Feb 3, 2025

ryanofsky referenced this in commit 9217d71ebb on Feb 3, 2025

ryanofsky referenced this in commit 7bbb1caf92 on Feb 3, 2025

ryanofsky referenced this in commit 177e285fff on Feb 4, 2025

ryanofsky referenced this in commit aba72ceb0c on Feb 4, 2025

ryanofsky referenced this in commit 5b73974a9a on Feb 5, 2025

ryanofsky referenced this in commit c8239c5d30 on Feb 5, 2025

ryanofsky referenced this in commit 29629eadca on Feb 7, 2025

ryanofsky referenced this in commit 64ee50632b on Feb 7, 2025

ryanofsky referenced this in commit bb37124dd5 on Feb 7, 2025

ryanofsky referenced this in commit 8ca1cc4285 on Feb 7, 2025

ryanofsky referenced this in commit cfdfd9a082 on Feb 10, 2025

ryanofsky referenced this in commit 1b3613505d on Feb 10, 2025

ryanofsky referenced this in commit cfe493a35b on Feb 10, 2025

ryanofsky referenced this in commit 351615e6f4 on Feb 10, 2025

ryanofsky referenced this in commit 76abe4a87d on Feb 10, 2025

ryanofsky referenced this in commit 6b350f593f on Feb 13, 2025

ryanofsky referenced this in commit 7da301054d on Feb 13, 2025

ryanofsky referenced this in commit ab0c98bb16 on Feb 24, 2025

ryanofsky referenced this in commit 4332cbe3a0 on Feb 24, 2025

ryanofsky referenced this in commit c2eb40a809 on Feb 25, 2025

ryanofsky referenced this in commit 20cf6ff0d0 on Feb 25, 2025

ryanofsky referenced this in commit a36912427a on Feb 25, 2025

ryanofsky referenced this in commit 2fe506867e on Feb 25, 2025

ryanofsky referenced this in commit 7d1cae0a38 on Mar 11, 2025

ryanofsky referenced this in commit bf530ec394 on Mar 11, 2025

ryanofsky referenced this in commit 3b7025a26f on Mar 12, 2025

ryanofsky referenced this in commit bcd45c290b on Mar 12, 2025

ryanofsky referenced this in commit b0506c8e5a on Mar 17, 2025

ryanofsky referenced this in commit 2a640e1f71 on Mar 17, 2025

ryanofsky referenced this in commit 0ac2cf5990 on Mar 17, 2025

ryanofsky referenced this in commit b4ed0bb265 on Mar 18, 2025

ryanofsky referenced this in commit b5813cf553 on Mar 18, 2025

ryanofsky referenced this in commit 7c0ed88b8b on Mar 31, 2025

ryanofsky referenced this in commit 066d5c4931 on Mar 31, 2025

ryanofsky referenced this in commit a7a92f8441 on Mar 31, 2025

ryanofsky referenced this in commit abdf3cb645 on Apr 2, 2025

ryanofsky referenced this in commit 9f41c688f1 on Apr 2, 2025

janus referenced this in commit 8caec90ca0 on Sep 7, 2025

Compiler warnings from capnproto when building via add_subdirectory #138