build: don’t clobber user/superproject c++ version #140

1. 
   theuni commented at 4:01 pm on January 30, 2025: contributor

   This allows a vendored libmultiprocess to inherit the c++ version from the main project
2. ryanofsky approved
3. 
   ryanofsky commented at 4:22 pm on January 30, 2025: collaborator

   Sorry I missed this in #136. Code review ACK bf07b262ba43a000f7605d050de2b6e39fd350e7
4. 
   TheCharlatan commented at 4:23 pm on January 30, 2025: collaborator

   lgtm
5. in CMakeLists.txt:8 in bf07b262ba outdated

   4@@ -5,7 +5,9 @@
   5 cmake_minimum_required(VERSION 3.8)
   6 
   7 project("Libmultiprocess" CXX)
   8-set(CMAKE_CXX_STANDARD 17)
   9+if(NOT DEFINED CMAKE_CXX_STANDARD)
   

   ---

   ---

   

   ryanofsky commented at 4:27 pm on January 30, 2025:

   In commit “build: don’t clobber user/superproject c++ version” (bf07b262ba43a000f7605d050de2b6e39fd350e7)

   I’m wondering if you think it might be better to do

   0if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
   1  set(CMAKE_CXX_STANDARD 17)
   2  set(CMAKE_CXX_STANDARD_REQUIRED YES)
   3endif()
   

   to handle the CMAKE_CXX_STANDARD and CMAKE_CXX_STANDARD_REQUIRED variables together instead of separately, to avoid clobbering CMAKE_CXX_STANDARD_REQUIRED, and to be more consistent with parent project detection code below.

   ---

   

   theuni commented at 6:29 pm on January 30, 2025:

   Done.

   ---

   

   hebasto commented at 6:42 pm on January 30, 2025:

   Done.

   Did you push the correct branch?

   ---

   

   theuni commented at 6:49 pm on January 30, 2025:

   Heh, whoops. Thanks. Fixed.
6. ryanofsky approved
7. 
   ryanofsky commented at 4:28 pm on January 30, 2025: collaborator

   I’m wondering if fix suggested below might make more sense. Happy to use whichever fix you prefer.
8. theuni force-pushed on Jan 30, 2025
9. build: don't clobber user/superproject c++ version

   This allows a vendored libmultiprocess to inherit the c++ version from the
   main project
   
   Co-authored-by: Ryan Ofsky <ryan@ofsky.org>

   df2153551e
10. theuni force-pushed on Jan 30, 2025
11. hebasto approved
12. 
    hebasto commented at 6:54 pm on January 30, 2025: member

    ACK df2153551e1bb05f9796fae75817051d52b86622.
13. ryanofsky approved
14. 
    ryanofsky commented at 7:19 pm on January 30, 2025: collaborator

    Code review ACK df2153551e1bb05f9796fae75817051d52b86622
15. ryanofsky merged this on Jan 30, 2025
16. ryanofsky closed this on Jan 30, 2025

    ---

17. ryanofsky referenced this in commit 8959938ed4 on Feb 3, 2025
18. ryanofsky referenced this in commit 37fb62c3a5 on Feb 4, 2025
19. ryanofsky referenced this in commit 1d75538a32 on Feb 5, 2025
20. ryanofsky referenced this in commit 9437e6846f on Feb 7, 2025
21. ryanofsky referenced this in commit a4a8f7a7ba on Feb 7, 2025
22. ryanofsky referenced this in commit 3a95817ece on Feb 10, 2025
23. Sjors referenced this in commit 6aabfcb615 on Feb 10, 2025
24. Sjors referenced this in commit 1746618e08 on Feb 13, 2025
25. ryanofsky referenced this in commit 83e40d3b52 on Feb 24, 2025
26. ryanofsky referenced this in commit 8619f03ec2 on Feb 24, 2025
27. ryanofsky referenced this in commit cbb7b41c20 on Feb 24, 2025
28. fanquake referenced this in commit 01f7715766 on Feb 25, 2025
29. fanquake referenced this in commit ba0a4391ff on Feb 25, 2025
30. janus referenced this in commit 86cb86b050 on Sep 1, 2025

Contributors
theuni ryanofsky TheCharlatan hebasto