cleanup: initialize vars in the EventLoop constructor in the correct order #143

1. 
   theuni commented at 6:06 pm on January 31, 2025: contributor

   This legitimate warning pops up when built with clang 20 and Core’s flags:

   warning: field 'm_context' will be initialized after field 'm_task_set' [-Wreorder-ctor]

   It looks like there are no dependency issues here and the reordering is safe, but please let me know if I’m wrong.

2. cleanup: initialize vars in the EventLoop constructor in the correct order

   This fixes:
   warning: field 'm_context' will be initialized after field 'm_task_set' [-Wreorder-ctor]

   f52d08c7f0
3. ryanofsky approved
4. 
   ryanofsky commented at 9:02 pm on January 31, 2025: collaborator

   Code review ACK f52d08c7f0fda95b25c984d39c5e53ebdc57323f. Looks good, thanks for the fix!

   Again will probably merge this Monday in case anyone else wants to review, but can merge sooner if that would be helpful.

5. hebasto approved
6. 
   hebasto commented at 11:56 pm on January 31, 2025: member

   ACK f52d08c7f0fda95b25c984d39c5e53ebdc57323f, tested on Ubuntu 24.04:

   0$ cmake -B build -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_CXX_FLAGS=-Wreorder-ctor
   1$ cmake --build build
   

7. ryanofsky merged this on Feb 3, 2025
8. ryanofsky closed this on Feb 3, 2025

   ---

9. ryanofsky referenced this in commit 8959938ed4 on Feb 3, 2025
10. ryanofsky referenced this in commit 37fb62c3a5 on Feb 4, 2025
11. ryanofsky referenced this in commit 1d75538a32 on Feb 5, 2025
12. ryanofsky referenced this in commit 9437e6846f on Feb 7, 2025
13. ryanofsky referenced this in commit a4a8f7a7ba on Feb 7, 2025
14. ryanofsky referenced this in commit 3a95817ece on Feb 10, 2025
15. Sjors referenced this in commit 6aabfcb615 on Feb 10, 2025
16. Sjors referenced this in commit 1746618e08 on Feb 13, 2025
17. ryanofsky referenced this in commit 83e40d3b52 on Feb 24, 2025
18. ryanofsky referenced this in commit 8619f03ec2 on Feb 24, 2025
19. ryanofsky referenced this in commit cbb7b41c20 on Feb 24, 2025
20. fanquake referenced this in commit 01f7715766 on Feb 25, 2025
21. fanquake referenced this in commit ba0a4391ff on Feb 25, 2025
22. janus referenced this in commit 86cb86b050 on Sep 1, 2025

Contributors
theuni ryanofsky hebasto