cmake: Suppress compiler warnings from capnproto headers #146

pull ryanofsky wants to merge 2 commits into bitcoin-core:master from ryanofsky:pr/inc2 changing 1 files +7 −8
  1. ryanofsky commented at 4:50 pm on February 3, 2025: collaborator

    Tweak target_link_libraries calls to correctly declare dependencies on capnproto libraries as public, so capnproto include directories get correctly added to downstream targets. Without this, compiler warnings can be triggered from capnproto headers because they are not treated like external headers.

    Fixes https://github.com/chaincodelabs/libmultiprocess/issues/138

    This should be an alternative to #141

  2. cmake: Suppress compiler warnings from capnproto headers
    Tweak target_link_libraries calls to correctly declare dependencies on
    capnproto libraries as public, so capnproto include directories get correctly
    added to downstream targets. Without this, compiler warnings can be triggered
    from capnproto headers because they are not treated like external headers.
    
    Fixes #138
    65c7048251
  3. cmake: Simplify capnp include handling
    Stop using lower level target_include_directories to add
    CAPNP_INCLUDE_DIRECTORY includes. This is no longer needed now that newer
    capnproto releases provide targets that set their own includes.
    
    This change is based on some similar cleanups originally implemented by
    Cory Fields <cory-nospam-@coryfields.com> in
    https://github.com/chaincodelabs/libmultiprocess/pull/141
    72326b5d1e
  4. hebasto commented at 4:54 pm on February 3, 2025: member
    Concept ACK.
  5. ryanofsky merged this on Feb 3, 2025
  6. ryanofsky closed this on Feb 3, 2025

  7. ryanofsky referenced this in commit 8959938ed4 on Feb 3, 2025
  8. ryanofsky referenced this in commit 37fb62c3a5 on Feb 4, 2025
  9. ryanofsky referenced this in commit 1d75538a32 on Feb 5, 2025
  10. ryanofsky referenced this in commit 9437e6846f on Feb 7, 2025
  11. ryanofsky referenced this in commit a4a8f7a7ba on Feb 7, 2025
  12. ryanofsky referenced this in commit 3a95817ece on Feb 10, 2025
  13. Sjors referenced this in commit 6aabfcb615 on Feb 10, 2025
  14. Sjors referenced this in commit 1746618e08 on Feb 13, 2025
  15. ryanofsky referenced this in commit 83e40d3b52 on Feb 24, 2025
  16. ryanofsky referenced this in commit 8619f03ec2 on Feb 24, 2025
  17. ryanofsky referenced this in commit cbb7b41c20 on Feb 24, 2025
  18. fanquake referenced this in commit 01f7715766 on Feb 25, 2025
  19. fanquake referenced this in commit ba0a4391ff on Feb 25, 2025
  20. janus referenced this in commit 86cb86b050 on Sep 1, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me