refactor: Fix compiler and clang-tidy warnings #152

1. 
   ryanofsky commented at 4:13 am on February 5, 2025: collaborator

   Most of these changes are not my own. This is combination of commits from #144 and #151 which fix a variety of compiler warnings.

   Several of the fixes are just suppressions, so followups can be done to improve code and fix problems more completely. More details can be found in #144.

2. clang-tidy: Disable `misc-use-anonymous-namespace` check

   The benefit of this check is questionable, so it has been disabled.
   See: https://clang.llvm.org/extra/clang-tidy/checks/misc/use-anonymous-namespace.html

   359a6157af
3. clang-tidy: Disable `performance-avoid-endl` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/performance/avoid-endl.html

   00036c0648
4. clang-tidy: Fix `bugprone-crtp-constructor-accessibility` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/empty-catch.html

   c068596ac3
5. clang-tidy: Suppress `bugprone-empty-catch` check warning

   See: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/empty-catch.html

   8170d3d421
6. clang-tidy: Fix `modernize-type-traits` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/modernize/type-traits.html

   4a2508c499
7. clang-tidy: Fix `misc-const-correctness` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/misc/const-correctness.html
   
   Co-authored-by: Ryan Ofsky <ryan@ofsky.org>

   848c902dd0
8. clang-tidy: Fix `misc-include-cleaner` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html

   15c77e9722
9. clang-tidy: Fix `misc-use-internal-linkage` check

   See: https://clang.llvm.org/extra/clang-tidy/checks/misc/use-internal-linkage.html

   c665a43f9c
10. clang-tidy: Fix `performance-unnecessary-value-param` check

    See: https://clang.llvm.org/extra/clang-tidy/checks/performance/unnecessary-value-param.html

    01ef094b4c
11. clang-tidy: Fix `readability-avoid-nested-conditional-operator` check

    See: https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-nested-conditional-operator.html

    4abaa98429
12. clang-tidy: Fix `readability-avoid-return-with-void-value` check

    See: https://clang.llvm.org/extra/clang-tidy/checks/readability/avoid-return-with-void-value.html
    
    Co-authored-by: Vasil Dimov <vd@FreeBSD.org>

    68c1c6c51a
13. clang-tidy: Fix `readability-container-size-empty` check

    See: https://clang.llvm.org/extra/clang-tidy/checks/readability/container-size-empty.html

    593807ab5b
14. clang-tidy: Suppress `performance-enum-size` check warning

    See: https://clang.llvm.org/extra/clang-tidy/checks/performance/enum-size.html
    
    Co-authored-by: Vasil Dimov <vd@FreeBSD.org>

    a02c0794fd
15. refactor: Fix `-Wsign-compare` compiler warning

    Co-authored-by: Ryan Ofsky <ryan@ofsky.org>

    0b8b7f92ca
16. ryanofsky merged this on Feb 5, 2025
17. ryanofsky closed this on Feb 5, 2025

    ---

18. ryanofsky referenced this in commit 1d75538a32 on Feb 5, 2025
19. ryanofsky referenced this in commit 9437e6846f on Feb 7, 2025
20. ryanofsky referenced this in commit a4a8f7a7ba on Feb 7, 2025
21. ryanofsky referenced this in commit 3a95817ece on Feb 10, 2025
22. Sjors referenced this in commit 6aabfcb615 on Feb 10, 2025
23. Sjors referenced this in commit 1746618e08 on Feb 13, 2025
24. ryanofsky referenced this in commit 83e40d3b52 on Feb 24, 2025
25. ryanofsky referenced this in commit 8619f03ec2 on Feb 24, 2025
26. ryanofsky referenced this in commit cbb7b41c20 on Feb 24, 2025
27. fanquake referenced this in commit 01f7715766 on Feb 25, 2025
28. fanquake referenced this in commit ba0a4391ff on Feb 25, 2025
29. janus referenced this in commit 86cb86b050 on Sep 1, 2025

Contributors
ryanofsky