refactor: Avoid using std::format #157

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/nf changing 2 files +4 −4
  1. ryanofsky commented at 7:03 pm on February 7, 2025: collaborator

    Partially revert #156 due to lack of compiler support for std::format, as reported https://github.com/chaincodelabs/libmultiprocess/pull/156#issuecomment-2643476222 and https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2643619428

    Technically it means this code is using locale dependent functions again, though I think in practice results will not be locale dependent because these are just integers not floating point numbers being formatted.

    This code could be written to use std::to_chars and be more independent, at the cost being slightly more complicated. Could be considered for a followup.

  2. refactor: Avoid using std::format
    Partially revert #156 due to lack of compiler support for std::format, as
    reported
    https://github.com/chaincodelabs/libmultiprocess/pull/156#issuecomment-2643476222
    and https://github.com/bitcoin/bitcoin/pull/31741#issuecomment-2643619428
    
    Technically it means this code is using locale dependent functions again,
    though I think in practice results will not be locale dependent because these
    are just integers not floating point numbers being formatted.
    
    This code could be written to use std::to_chars and be more independent, at the
    cost being slightly more complicated. Could be considered for a followup.
    eca8fd3eee
  3. ryanofsky merged this on Feb 7, 2025
  4. ryanofsky closed this on Feb 7, 2025

  5. ryanofsky referenced this in commit a4a8f7a7ba on Feb 7, 2025
  6. ryanofsky referenced this in commit 3a95817ece on Feb 10, 2025
  7. Sjors referenced this in commit 6aabfcb615 on Feb 10, 2025
  8. Sjors referenced this in commit 1746618e08 on Feb 13, 2025
  9. ryanofsky referenced this in commit 83e40d3b52 on Feb 24, 2025
  10. ryanofsky referenced this in commit 8619f03ec2 on Feb 24, 2025
  11. ryanofsky referenced this in commit cbb7b41c20 on Feb 24, 2025
  12. fanquake referenced this in commit 01f7715766 on Feb 25, 2025
  13. fanquake referenced this in commit ba0a4391ff on Feb 25, 2025
  14. janus referenced this in commit 86cb86b050 on Sep 1, 2025


ryanofsky


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me