type-function.h: Fix CustomBuildField overload #181

pull ryanofsky wants to merge 2 commits into bitcoin-core:master from ryanofsky:pr/ffn changing 5 files +12 −1
  1. ryanofsky commented at 7:58 pm on June 3, 2025: collaborator

    Fix std::function CustomBuildField overload which is incompatible with a recent change in 3a96cdc18f2d1ca202fbc91551f27097fd7ec7f6 from #172 which changed generated IPC client code to pass it an rvalue std::function reference instead of an lvalue reference.

    Motivation for this change is to avoid a build error in https://github.com/bitcoin/bitcoin/pull/29409, when rebased on top of https://github.com/bitcoin/bitcoin/pull/32641 which includes #172.

  2. type-function.h: Fix CustomBuildField overload
    Fix std::function CustomBuildField overload which is incompatible with a recent
    change in 3a96cdc18f2d1ca202fbc91551f27097fd7ec7f6 from
    https://github.com/bitcoin-core/libmultiprocess/pull/172 which changed
    generated IPC client code to pass it an rvalue std::function reference instead
    of an lvalue reference.
    
    There was no test coverage for the type-function.h header earlier but the next
    commit adds a test which would have caught the problem in the CustomBuildField
    declaration.
    
    Motivation for this change is to avoid a build error in
    https://github.com/bitcoin/bitcoin/pull/29409 when rebased on top of
    https://github.com/bitcoin/bitcoin/pull/32641 which includes
    https://github.com/bitcoin-core/libmultiprocess/pull/172
    8b96229da5
  3. test: Add coverage for type-function.h 688140b1df
  4. TheCharlatan approved
  5. TheCharlatan commented at 8:22 am on June 11, 2025: collaborator
    ACK 688140b1dffc78a97a5a16f62b540a55824f4091
  6. ryanofsky merged this on Jun 11, 2025
  7. ryanofsky closed this on Jun 11, 2025

  8. ryanofsky referenced this in commit 07dda23f6b on Jun 13, 2025
  9. ryanofsky referenced this in commit 5bf57b1ea2 on Jun 16, 2025
  10. ryanofsky referenced this in commit e0e4d3bd05 on Jun 16, 2025
  11. Sjors referenced this in commit ebfb66188e on Jun 24, 2025
  12. ryanofsky referenced this in commit 9b4ec43f78 on Jun 24, 2025
  13. Sjors referenced this in commit 063587c2de on Jun 27, 2025
  14. ryanofsky referenced this in commit 96bcbb60a6 on Jul 1, 2025
  15. ryanofsky referenced this in commit 6e40719c06 on Jul 1, 2025
  16. ryanofsky referenced this in commit ca509dd2b9 on Jul 1, 2025
  17. ryanofsky referenced this in commit e886c65b6b on Aug 8, 2025
  18. Sjors referenced this in commit 8ce8288ee6 on Aug 12, 2025
  19. fanquake referenced this in commit f58de8749e on Aug 18, 2025
  20. janus referenced this in commit d7ab135840 on Sep 15, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me