This PR fixes #190 by reducing the maximum size of characters to from 1000 to 200.
This is achieved by creating a new struct LogOptions
The LogOptions struct will contain
i) The log callback function pointer
ii) The maximum character to pass to LogEscape
The main motivation is to reduce the verbosity of the logs and make
LogEscape max_size configurable.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
53@@ -54,7 +54,7 @@ int main(int argc, char** argv)
54 std::cerr << argv[1] << " is not a number or is larger than an int\n";
55 return 1;
56 }
57- mp::EventLoop loop("mpcalculator", LogPrint);
58+ mp::EventLoop loop("mpcalculator", {LogPrint});
187+EventLoop::EventLoop(const char* exe_name, LogOptions log_opts, void* context)
188 : m_exe_name(exe_name),
189 m_io_context(kj::setupAsyncIo()),
190 m_task_set(new kj::TaskSet(m_error_handler)),
191- m_log_fn(std::move(log_fn)),
192+ m_log_opts(log_opts),
In commit “event loop: make log options configurable” (e6013d793e1be2d1becdbe422c7c4ce5bc1d9e28)
I think it might be a little better if the PR avoided changing the EventLoop signature, and just assigned m_log_opts.log_fn = log_fn in the body of the constructor. This would prevent downstream code in bitcoin core that uses the EventLoop from breaking, and make it a little easier to merge the subtree PR, not breaking the build in the subtree bump commit. Another option to stay compatible could be to have two constructors, though I like that idea a little less.
Forced pushed to address @ryanofsky recent comment
59@@ -60,6 +60,7 @@ class TestSetup
60
61 TestSetup(bool client_owns_connection = true)
62 : thread{[&] {
63+
In commit “eventloop: add LogOptions struct” (d9eb7fb8cbeb58d3843f3d32974831b26613bc92)
Note: extra newline is added here, should be no need to change this file anymore
- The LogOptions struct will contain
i) The log callback function pointer
ii) The maximum character to pass to LogEscape
- This also reduce the verbosity of the logs and make
LogEscape max_size configurable.