cmake: search capnproto in package mode only #203

pull purpleKarrot wants to merge 1 commits into bitcoin-core:master from purpleKarrot:capnproto-no-module changing 1 files +1 −1
  1. purpleKarrot commented at 8:34 am on September 3, 2025: contributor

    CMake does not provide a FindCapnProto.cmake module and never will, because CapnProto already ships CMake package configuration files. Make sure to skip the search for the CMake module and avoid the confusing “By not providing …” error message if CapnProto is not installed.

    Current error message if CapnProto is not intalled:

     0CMake Error at CMakeLists.txt:16 (find_package):
     1  By not providing "FindCapnProto.cmake" in CMAKE_MODULE_PATH this project
     2  has asked CMake to find a package configuration file provided by
     3  "CapnProto", but CMake did not find one.
     4
     5  Could not find a package configuration file provided by "CapnProto"
     6  (requested version 0.7) with any of the following names:
     7
     8    CapnProtoConfig.cmake
     9    capnproto-config.cmake
    10
    11  Add the installation prefix of "CapnProto" to CMAKE_PREFIX_PATH or set
    12  "CapnProto_DIR" to a directory containing one of the above files.  If
    13  "CapnProto" provides a separate development package or SDK, be sure it has
    14  been installed.
    15
    16
    17-- Configuring incomplete, errors occurred!
    

    with NO_MODULE:

     0CMake Error at CMakeLists.txt:16 (find_package):
     1  Could not find a package configuration file provided by "CapnProto"
     2  (requested version 0.7) with any of the following names:
     3
     4    CapnProtoConfig.cmake
     5    capnproto-config.cmake
     6
     7  Add the installation prefix of "CapnProto" to CMAKE_PREFIX_PATH or set
     8  "CapnProto_DIR" to a directory containing one of the above files.  If
     9  "CapnProto" provides a separate development package or SDK, be sure it has
    10  been installed.
    11
    12
    13-- Configuring incomplete, errors occurred!
    
  2. cmake: search capnproto in package mode only
    CMake does not provide a `FindCapnProto.cmake` module and never will,
    because CapnProto already ships CMake package configuration files.
    Make sure to skip the search for the CMake module and avoid the
    confusing "By not providing ..." error message if CapnProto is not
    installed.
    3bee07ab33
  3. DrahtBot commented at 8:34 am on September 3, 2025: none

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. Sjors commented at 10:00 am on September 3, 2025: member
    See also https://github.com/bitcoin/bitcoin/pull/33290, it’s nice to have the red message there be less confusing.
  5. purpleKarrot commented at 4:02 pm on September 3, 2025: contributor

    See also bitcoin/bitcoin#33290, it’s nice to have the red message there be less confusing.

    I have seen that. It is what motivated this PR. :-)

  6. ryanofsky approved
  7. ryanofsky commented at 9:08 pm on September 3, 2025: collaborator
    Code review ACK 3bee07ab3367eb77e3943859c845ec0c0195f9b8. Thanks for the improvement!
  8. Sjors commented at 7:26 am on September 4, 2025: member
    cc @hebasto the CMake guru :-)
  9. ryanofsky merged this on Sep 4, 2025
  10. ryanofsky closed this on Sep 4, 2025

  11. hebasto commented at 3:19 pm on September 4, 2025: member

    Post-merge ACK 3bee07ab3367eb77e3943859c845ec0c0195f9b8.

    cc @hebasto the CMake guru :-)

    It’s @purpleKarrot’s title, not mine :)

  12. ryanofsky referenced this in commit a334bbe9b7 on Sep 5, 2025
  13. fanquake referenced this in commit 9c6fa07b12 on Sep 8, 2025
  14. Sjors referenced this in commit 132621fc01 on Sep 23, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me