ci: Test minimum cmake version in olddeps job #208
pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/oldcmake changing 3 files +31 −6-
ryanofsky commented at 2:04 pm on September 8, 2025: collaboratorAdd CI job to test minimum version of cmake that can be used to build. Current minimum version 3.12, since that’s version that added c++20 support according to #164.
-
DrahtBot commented at 2:04 pm on September 8, 2025: none
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK hebasto If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
ci: Test minimum cmake version in olddeps job 0f580397c9
-
ryanofsky force-pushed on Sep 8, 2025
-
ryanofsky commented at 2:52 pm on September 8, 2025: collaboratorRebased 2c6ea2eb842eb5b694923d299631862cb3a0b9f1 -> 0f580397c9135688ab02f9f1e1089b5d247bb92d (
pr/oldcmake.1->pr/oldcmake.2, compare) to fix ctest directory errors and conflict with #207 -
hebasto approved
-
hebasto commented at 3:02 pm on September 9, 2025: memberACK 0f580397c9135688ab02f9f1e1089b5d247bb92d, I have reviewed the code and it looks OK. CI log also looks reasonable.
-
ryanofsky commented at 6:34 pm on September 9, 2025: collaboratorThanks for the review! Will go ahead and merge since I’m about to open another PR which depends on this
-
ryanofsky merged this on Sep 9, 2025
-
ryanofsky closed this on Sep 9, 2025
-
ryanofsky referenced this in commit 535fa0ad0d on Sep 17, 2025
-
fanquake referenced this in commit edb871cba2 on Sep 19, 2025
-
Sjors referenced this in commit 132621fc01 on Sep 23, 2025
-
ryanofsky referenced this in commit 5bb3cbdfba on Oct 2, 2025
-
ryanofsky referenced this in commit abcd4c4ff9 on Oct 7, 2025
-
fanquake referenced this in commit a14e7b9dee on Oct 16, 2025
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me