doc: fix typos #224
pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:ai_typos changing 1 files +3 −3-
fanquake commented at 4:28 pm on October 3, 2025: memberPointed out by the AI here: https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3360399365.
-
fanquake renamed this:
doc: fix typo
doc: fix typos
on Oct 3, 2025 -
DrahtBot commented at 4:28 pm on October 3, 2025: none
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
fanquake force-pushed on Oct 3, 2025
-
in test/mp/test/test.cpp:312 in 6c7113cb07
308@@ -309,7 +309,7 @@ KJ_TEST("Calling IPC method, disconnecting and blocking during the call") 309 signal.set_value(); 310 } 311 312-KJ_TEST("Make simultaneous IPC callbacks with same request_thread and callback_thread") 313+KJ_TEST("Make simultaneous IPC callbacks with the same request_thread and callback_thread")
ryanofsky commented at 7:58 pm on October 3, 2025:In commit “doc: fix typos” (6c7113cb07e4634ef231dd8a40122d0cc5f5a074)
This change is good, but in case you feel like taking it further I think
"Make simultaneous IPC calls to trigger "thread busy" error'"might be a little better description of the test. I can also make that change later since #222 and maybe #218 will also update this test
fanquake commented at 8:10 pm on October 3, 2025:Sure, pushed that up.ryanofsky approvedryanofsky commented at 8:01 pm on October 3, 2025: collaboratorCode review ACK 6c7113cb07e4634ef231dd8a40122d0cc5f5a074. Looks good, thanks for fixing thesefanquake force-pushed on Oct 3, 2025ryanofsky approvedryanofsky commented at 8:49 pm on October 3, 2025: collaboratorCode review ACK 7189bd447aaa1f5eef1b3063efc0e9b2574852f4. Thanks!in test/mp/test/test.cpp:312 in 7189bd447a outdated
308@@ -309,7 +309,7 @@ KJ_TEST("Calling IPC method, disconnecting and blocking during the call") 309 signal.set_value(); 310 } 311 312-KJ_TEST("Make simultaneous IPC callbacks with same request_thread and callback_thread") 313+KJ_TEST("Make simultaneous IPC calls to trigger 'thread busy' error")
ryanofsky commented at 9:31 pm on October 3, 2025:In commit “doc: fix typos” (7189bd447aaa1f5eef1b3063efc0e9b2574852f4)
Could also
s/setup/set up/on line 319 below to implement LLM linter ‘setup (verb) -> set up [wrong form: “setup” is a noun; the verb phrase is “set up”]’ suggestion from https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3360399365
fanquake commented at 9:33 pm on October 3, 2025:Added.ryanofsky approved1434642b38doc: fix typos
Pointed out by the AI here: https://github.com/bitcoin/bitcoin/pull/33518#issuecomment-3360399365.
fanquake force-pushed on Oct 3, 2025ryanofsky approvedryanofsky commented at 9:37 pm on October 3, 2025: collaboratorCode review ACK 1434642b3804e54d9607dcf22e58019b203d05f7. No idea how you are this fast. Thanks for the update!maflcko commented at 10:37 am on October 6, 2025: contributorlgtm ACK 1434642b3804e54d9607dcf22e58019b203d05f7ryanofsky merged this on Oct 7, 2025ryanofsky closed this on Oct 7, 2025
fanquake deleted the branch on Oct 7, 2025ryanofsky referenced this in commit 0f01e1577f on Oct 7, 2025ryanofsky referenced this in commit abcd4c4ff9 on Oct 7, 2025Sjors referenced this in commit 3e34afe882 on Oct 7, 2025fanquake referenced this in commit becf150013 on Oct 10, 2025Sjors referenced this in commit 7e61dcfa61 on Oct 10, 2025fanquake referenced this in commit a14e7b9dee on Oct 16, 2025
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC
More mirrored repositories can be found on mirror.b10c.me