Connect/disconnect log levels? #227

issue ryanofsky openend this issue on October 9, 2025
  1. ryanofsky commented at 1:19 pm on October 9, 2025: collaborator

    Originally posted by @Sjors in https://github.com/bitcoin/bitcoin/pull/33517#pullrequestreview-3313376282

    Not directly related to the changes here, but it’s a bit odd that clean disconnects are logged at the info level (always visible) while new connections are logged at the debug level (requires -debug=ipc).

    Disconnect:

    02025-10-08T07:19:16Z [ipc:info] {bitcoin-node-57287/b-capnp-loop-6497836} IPC server destroy N2mp11ProxyServerIN3ipc5capnp8messages6MiningEEE
    12025-10-08T07:19:16Z [ipc:info] {bitcoin-node-57287/b-capnp-loop-6497836} IPC server: socket disconnected.
    22025-10-08T07:19:16Z [ipc:info] {bitcoin-node-57287/b-capnp-loop-6497836} IPC server destroy N2mp11ProxyServerIN3ipc5capnp8messages4InitEEE
    

    Connect (-debug=ipc):

    02025-10-08T07:19:44Z [ipc] {bitcoin-node-57788/b-capnp-loop-6502845} IPC server recv request  [#1](/bitcoin-core-multiprocess/1/) Init.construct$Params
    12025-10-08T07:19:44Z [ipc] {bitcoin-node-57788/b-capnp-loop-6502845} IPC server send response [#1](/bitcoin-core-multiprocess/1/) Init.construct$Results
    22025-10-08T07:19:44Z [ipc] {bitcoin-node-57788/b-capnp-loop-6502845} IPC server recv request  [#2](/bitcoin-core-multiprocess/2/) Init.makeMining$Params
    32025-10-08T07:19:44Z [ipc] {bitcoin-node-57788/b-capnp-loop-6502845} IPC server post request  [#2](/bitcoin-core-multiprocess/2/) {bitcoin-node-57788/6502989 (from sv2-tp-57803/6502987)}
    42025-10-08T07:19:44Z [ipc] {bitcoin-node-57788/b-capnp-loop-6502845} IPC server send response [#2](/bitcoin-core-multiprocess/2/) Init.makeMining$Results
    

    The former seems too chatty, the latter too quiet. Maybe only have the “socket disconnected” message be at the info level and introduce a “socket connected” message.


ryanofsky


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-04 19:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me