doc/design.md and source code comments to improve readability.
doc: Fix typos and grammar in documentation and comments #234
pull enirox001 wants to merge 1 commits into bitcoin-core:master from enirox001:28_11_25_doc_fixes changing 5 files +16 −16-
enirox001 commented at 4:09 pm on November 28, 2025: contributorThis PR fixes various typos, spelling mistakes, and grammatical errors found in
-
DrahtBot commented at 4:09 pm on November 28, 2025: none
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- …"#include <d/file.capnp.proxy-types.h"> -> …"#include <d/file.capnp.proxy-types.h>" [extraneous ‘>’ after the closing quote makes the example include line malformed]
2026-01-09
-
enirox001 force-pushed on Nov 28, 2025
-
in include/mp/proxy-io.h:322 in c6b53010ac
317@@ -318,7 +318,7 @@ class EventLoop 318 }; 319 320 //! Single element task queue used to handle recursive capnp calls. (If server 321-//! makes an callback into the client in the middle of a request, while client 322+//! If the server makes a callback into the client in the middle of a request, while client 323 //! thread is blocked waiting for server response, this is what allows the
maflcko commented at 11:00 am on December 1, 2025:while client -> while the client [missing article]
maflcko commented at 11:03 am on December 1, 2025:Also, the line does not correctly continue the previous one.
maflcko commented at 8:10 am on December 22, 2025:@enirox001 Are you still working on this?
ryanofsky commented at 1:47 am on January 9, 2026:In commit “Fix various typos, spelling mistakes, and grammatical errors in design.md and source code comments.” (c6b53010acad1fc071d6afb52ff45179c00396a7)
Would be good to fix the line continuation. The problem is it repeats “(If server\nIf the server” and the parenthesis is never closed.
Other than that all the changes in this PR seem like improvements. If @enirox001 is not around to update this after maybe a week we could open another PR cleaning it up and crediting the source
enirox001 commented at 6:35 am on January 9, 2026:Thanks for the review and patience! I’ve addressed the remaining issues:
- Added missing article “the” before “client thread”
- Fixed the unclosed parenthesis at the end of the comment
- Corrected the line continuation issue
The comment now properly opens and closes the parenthesis explaining the recursive capnp call behavior. @maflcko @ryanofsky Ready for another look when you have a chance.
enirox001 force-pushed on Jan 9, 2026Fix various typos, spelling mistakes, and grammatical errors in design.md and source code comments. 458745e394in src/mp/proxy.cpp:110 in e321706af4
107 // ProxyClient capability pointers to null, so new method calls on client 108 // objects fail without triggering i/o or relying on event loop which may go 109 // out of scope or trigger obscure capnp i/o errors. 110 // 111- // The ProxySever cleanup handlers call user defined destructors on server 112+ // The ProxyServer cleanup handlers call user defined destructors on server
maflcko commented at 8:29 am on January 9, 2026:on server object -> on the server object [missing article makes the phrase grammatically incorrect; "the server object" clarifies the noun and improves comprehension]
enirox001 commented at 8:59 am on January 9, 2026:Thanks for the review.
Improved phrase for better clarification
enirox001 force-pushed on Jan 9, 2026maflcko commented at 9:05 am on January 9, 2026: contributorlgtm ACK 458745e39404f3344e80aa047a3ce75abf66d806ryanofsky approvedryanofsky commented at 3:56 pm on January 9, 2026: collaboratorCode review ACK 458745e39404f3344e80aa047a3ce75abf66d806. Thanks for the fixes!ryanofsky merged this on Jan 9, 2026ryanofsky closed this on Jan 9, 2026
This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-02-17 00:30 UTC
More mirrored repositories can be found on mirror.b10c.me