ci: Use persistent_worker for valgrind #126

pull maflcko wants to merge 1 commits into bitcoin-core:main from maflcko:main changing 1 files +11 −18

maflcko commented at 1:06 PM on May 18, 2023: contributor

Requested: #113 (comment)
ci: Use persistent_worker for valgrind 5d3adc2fcf

in .cirrus.yml:78 in 5d3adc2fcf

  77 | @@ -85,7 +78,7 @@ task:
  78 |      - sed -i 's|FuzzedDataProvider fuzzed_data_provider|return;FuzzedDataProvider fuzzed_data_provider|g'  ./src/test/fuzz/strprintf.cpp  # Avoid tinyformat issue

maflcko commented at 2:56 PM on May 18, 2023:

Unrelated: Can probably remove this?

in .cirrus.yml:50 in 5d3adc2fcf

  59 |      - apt update && apt install git -y
  60 |      - git clone https://github.com/bitcoin/bitcoin --depth=1 ./bitcoin-core
  61 | -    - mkdir -p /tmp/bitcoin-core/ci/scratch
  62 | -    - mv /tmp/cirrus-ci-build /tmp/bitcoin-core/ci/scratch/qa-assets
  63 | +    - mkdir -p ./bitcoin-core/ci/scratch/qa-assets
  64 | +    - mv ./fuzz_seed_corpus ./bitcoin-core/ci/scratch/qa-assets/

maflcko commented at 2:56 PM on May 18, 2023:

note: Need to check that this works

maflcko commented at 11:43 AM on May 22, 2023:

Made easier in https://github.com/bitcoin/bitcoin/pull/27672 (second commit)

fanquake commented at 11:56 AM on May 22, 2023:

https://github.com/bitcoin/bitcoin/pull/27672 is now merged.

dergoegge commented at 8:10 AM on May 19, 2023: member

19h runtime so far 🫣 What kind of toasters are they running these workers on? iirc Michael had a 5h run for the valgrind job on a 8 core AWS machine.

Anyway, this seems like a good solution if we are willing to pay the cost (I'm assuming this will cost compute credits as well).
maflcko commented at 8:43 AM on May 19, 2023: contributor

Anyway, this seems like a good solution if we are willing to pay the cost

It is using someone's leftover VM somewhere, so it's free :sweat_smile:
fanquake commented at 10:33 AM on May 20, 2023: member

@MarcoFalke did you wanna follow up with your comments, or merge this now?
maflcko commented at 10:58 AM on May 22, 2023: contributor

Yeah, maintainers can merge this if they think it is ready, reviewed and tested. I'll follow-up separately
fanquake merged this on May 22, 2023
fanquake closed this on May 22, 2023
maflcko commented at 1:09 PM on May 22, 2023: contributor

Follow-up fixes in https://github.com/bitcoin-core/qa-assets/pull/127

Contributors

maflcko

fanquake

dergoegge

Linked (view graph)

#113 Increase timeout or remove valgrind CI job?