Add script edge cases to script assets #297

pull benthecarman wants to merge 1 commits into bitcoin-core:main from benthecarman:script-assets-legacy-edge-cases changing 1 files +28 −1

benthecarman commented at 7:25 PM on October 7, 2026: none

Merges the feature_taproot.py dumps of the new legacy/ spenders in bitcoin/bitcoin#36455 and of sighash/hashtype0_byte_scriptpath into the script assets, using the merge from src/test/fuzz/script_assets_test_minimizer.cpp. The merge adds 27 cases with 37 new coverage edges. Each catches an interpreter bug the rest of the file misses.

These were discovered by finding gaps in alternate implementations (bitcoin-s and rbitcoin)
fanquake commented at 6:26 AM on October 16, 2026: member

@benthecarman can you rebase here?
benthecarman force-pushed on Oct 16, 2026
benthecarman commented at 6:32 AM on October 16, 2026: none

rebased
fanquake commented at 6:38 AM on October 16, 2026: member

Thanks, kicked the CI.

Add script edge cases to script assets

Merge the feature_taproot.py dumps of the new legacy/ spenders and of
sighash/hashtype0_byte_scriptpath into the script assets with the
script_assets_test_minimizer merge. The merge adds 27 cases with 37
new coverage edges.

Other implementations have gotten each of these wrong, and no other
case in the file catches an interpreter that does.

ddd1e61acd

benthecarman force-pushed on Oct 21, 2026
benthecarman commented at 5:30 PM on October 21, 2026: none

Redid this using the merge from script_assets_test_minimizer.cpp instead of appending by hand.

Contributors

benthecarman

fanquake