Make aux_rnd32==NULL behave identical to 0x0000..00. #1002

pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202110_bip341auxzero changing 3 files +20 −9

sipa commented at 5:05 PM on October 30, 2021: contributor

BIP340's default signing algorithm always requires an aux_rnd argument, but permits using an all-zero one when no randomness is available.

Make secp256k1_schnorrsig_sign follow this even when aux_rnd32==NULL, by treating the same as if an all-zero byte array was provided as input.

Make aux_rnd32==NULL behave identical to 0x0000..00.

BIP340's default signing algorithm always requires an aux_rnd argument,
but permits using an all-zero one when no randomness is available.

Make secp256k1_schnorrsig_sign follow this even when aux_rnd32==NULL,
by treating the same as if an all-zero byte array was provided as
input.

5324f8942d

sipa cross-referenced this on Oct 30, 2021 from issue Add test vectors for BIP 341 SigMsg by giacomocaironi
junderw commented at 5:21 PM on October 30, 2021: none

ACK 5324f89
junderw cross-referenced this on Oct 30, 2021 from issue feat: add Schnorr signature support by OttoAllmendinger
real-or-random commented at 10:38 PM on October 30, 2021: contributor

Concept ACK. We should stay in line with the BIP.
jonasnick commented at 4:05 PM on October 31, 2021: contributor
ACK 5324f8942dd322448fae6c9b225ecac2854fa7e2

Without this PR, the doc for secp256k1_nonce_function_bip340 is wrong:
If a data pointer is passed, it is assumed to be a pointer to 32 bytes of

auxiliary random data as defined in BIP-340. If the data pointer is NULL,

the nonce derivation procedure follows BIP-340 by setting the auxiliary

random data to zero.
elichai commented at 4:32 PM on October 31, 2021: contributor

ACK 5324f8942dd322448fae6c9b225ecac2854fa7e2
real-or-random approved
real-or-random commented at 4:41 PM on October 31, 2021: contributor

utACK 5324f8942dd322448fae6c9b225ecac2854fa7e2
real-or-random merged this on Oct 31, 2021
real-or-random closed this on Oct 31, 2021
sipa referenced this in commit 440f7ec80e on Oct 31, 2021
sipa cross-referenced this on Oct 31, 2021 from issue Update libsecp256k1 subtree to current master by sipa
sipa referenced this in commit d057eae556 on Dec 2, 2021
fanquake referenced this in commit c4a1e09a8c on Dec 3, 2021
sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
fanquake referenced this in commit c06cda3e48 on Dec 18, 2021
jonasnick cross-referenced this on Jan 2, 2022 from issue Sync Upstream by jonasnick
real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
gwillen referenced this in commit 35d6112a72 on May 25, 2022
janus referenced this in commit 879a9a27b9 on Jul 10, 2022
patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
landabaso cross-referenced this on Jun 28, 2023 from issue Insight on Default Value Strategy for `auxRand` in Schnorr Signing by landabaso
vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors