This one should really be only a refactor with the goal to silence static analysis warnings. clang-14 (trunk) recently added one in commit https://github.com/llvm/llvm-project/commit/f62d18ff140f67a8776a7a3c62a75645d8d540b5 and I expect other tools will offer similar warnings.
Follow up to #1006, which was not a refactor.
This fixes a compiler warning:
./src/ecdsa_impl.h:312:12: warning: use of bitwise '&' with boolean operands [-Wbitwise-instead-of-logical]
return !secp256k1_scalar_is_zero(sigr) & !secp256k1_scalar_is_zero(sigs);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~I checked that this patch doesn't change the objdump, but 1006 did
ACK 16d132215cab68e57798927301268518bc1c3bf8
ACK 16d132215cab68e57798927301268518bc1c3bf8
This is a should be a no-op also because ! already results in type int. Quite a bit weird to have to add this cast, but apparently it can catch bugs in the real world (TM).
This is a should be a no-op also because ! already results in type int
Are you sure that operator! results in type int? At least in C++, it results in type bool: https://docs.microsoft.com/en-us/cpp/cpp/logical-negation-operator-exclpt
See C89 standard. Also, there is no bool type in C89.