build: replace backtick command substitution with $() #1025

pull fanquake wants to merge 1 commits into bitcoin-core:master from fanquake:remove_legacy_bash_notation changing 1 files +1 −1

fanquake commented at 11:02 AM on December 3, 2021: member

This is only needed for the very oldest of non-POSIX-compatible shells. Note that this code will also only be executed on macOS, where it'd be very unlikely to run into such a shell anyways.

Followup to #1019#pullrequestreview-815300521. I had thought there were more usages of this syntax, but seems like it's just the one.

See: https://github.com/koalaman/shellcheck/wiki/SC2006

Co-authored-by: Hennadii Stepanov 32963518+hebasto@users.noreply.github.com

build: replace backtick command substitution with $()

This is only needed for the very oldest of non-POSIX-compatible shells.
Note that this code will also only be executed on macOS, where it'd be
very unlikely to run into such a shell.

Followup to #1019.

See:
https://github.com/koalaman/shellcheck/wiki/SC2006

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

2b7c7497ef

elichai commented at 11:40 AM on December 3, 2021: contributor

LGTM 2b7c7497ef66eae3a178b666fe17af40495322a6

I wonder if it's possible to run the whole configure.ac file through shellcheck somehow
real-or-random approved
real-or-random commented at 12:03 PM on December 3, 2021: contributor

ACK 2b7c7497ef66eae3a178b666fe17af40495322a6
hebasto approved
hebasto commented at 1:26 PM on December 3, 2021: member

ACK 2b7c7497ef66eae3a178b666fe17af40495322a6, verified that this is the only case.
real-or-random merged this on Dec 3, 2021
real-or-random closed this on Dec 3, 2021
fanquake deleted the branch on Dec 4, 2021
sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
sipa cross-referenced this on Dec 15, 2021 from issue Update libsecp256k1 subtree to current master by sipa
jonasnick cross-referenced this on Jan 2, 2022 from issue Sync Upstream by jonasnick
real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
gwillen referenced this in commit 35d6112a72 on May 25, 2022
janus referenced this in commit 879a9a27b9 on Jul 10, 2022
patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors

Linked (view graph)

#1019 build: don't append valgrind CPPFLAGS if not installed (macOS)