This should be whitespace/comment only changes and should produce the same object code.
Switch to C89 comments in prep for making the whole codebase C89 compatible. #105
pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:c89_comments changing 38 files +803 −717-
gmaxwell commented at 3:34 PM on November 15, 2014: contributor
-
71712b27e5
Switch to C89 comments in prep for making the whole codebase C89 compatible.
This should be whitespace/comment only changes and should produce the same object code.
-
gmaxwell commented at 3:34 PM on November 15, 2014: contributor
Lets see if this gets me strangled. Its the most stupid of the required changes for C89.
-
sipa commented at 8:16 PM on November 15, 2014: contributor
utACK
-
sipa commented at 8:20 PM on November 15, 2014: contributor
Verified that the binary is identical.
-
sipa commented at 9:38 PM on November 16, 2014: contributor
No clue how I ended up finding that the resulting binary is identical; I can't reproduce that anymore...
-
gmaxwell commented at 9:42 PM on November 16, 2014: contributor
Cool. Yea, I didn't check that yet I assumed you would. Interesting, okay, I'll go find my mistake then. (or at least see if the binaries are identical for me)
-
sipa commented at 9:49 PM on November 16, 2014: contributor
I think I'm just not doing enough to make the result deterministic. I'm configuring/compiling with CFLAGS="-O0 -g0 -frandom-seed=bla".
-
gmaxwell commented at 11:02 PM on November 16, 2014: contributor
The non-determinism is, at a minimum, from macros using _ _ LINE _ _. (figured this out just by diffing the objdump -d output). I suggest you compare versions that have _ _ LINE _ _ replaced with 0? You shouldn't need -O0, and if you objdump you shouldn't need -g0.
I confirm that it's determinstic and unchanged for me once the line number is removed from the macro. Perhaps we should have that controlled by a define for easier testing?
-
- sipa merged this on Nov 17, 2014
- sipa closed this on Nov 17, 2014
- sipa referenced this in commit c48cdc4cb3 on Nov 17, 2014
