`_scratch_destroy`: move `VERIFY_CHECK` after invalid scrach space check #1114

pull siv2r wants to merge 1 commits into bitcoin-core:master from siv2r:scratch-destroy-bug changing 1 files +1 −1
  1. siv2r commented at 3:15 PM on June 29, 2022: contributor

    If we pass an invalid scratch pointer to secp256k1_scratch_destroy, the VERIFY_CHECK will probably fail, and libsecp will crash with the message

    src/scratch_impl.h:28: test condition failed: scratch->alloc_size == 0

    If VERIFY_CHECK after the invalid scratch space check, libsecp will call the error callback function with the "invalid scratch space" message instead.

  2. scratch_destroy: move VERIFY_CHECK after invalid scrach space check 1827c9bf2b
  3. jonasnick commented at 3:41 PM on June 29, 2022: contributor

    ACK 1827c9bf2b7d4bf6a78c2f387bdb3e885a71e292

  4. sipa commented at 3:43 PM on June 29, 2022: contributor

    utACK 1827c9bf2b7d4bf6a78c2f387bdb3e885a71e292

  5. jonasnick merged this on Jun 29, 2022
  6. jonasnick closed this on Jun 29, 2022
  7. siv2r deleted the branch on Jun 30, 2022
  8. dhruv referenced this in commit 2dfd7005d9 on Jul 19, 2022
  9. dhruv referenced this in commit 21e2acb595 on Jul 20, 2022
  10. dhruv referenced this in commit f70e7d8108 on Jul 20, 2022
  11. dhruv referenced this in commit 49704ff497 on Jul 20, 2022
  12. dhruv referenced this in commit a1ac8e1b7f on Jul 20, 2022
  13. hebasto referenced this in commit 07695f6c2d on Jul 21, 2022
  14. dhruv referenced this in commit e5166959a4 on Jul 21, 2022
  15. dhruv referenced this in commit 726cbfe06c on Jul 21, 2022
  16. dhruv referenced this in commit c354ccd3e6 on Jul 21, 2022
  17. dhruv referenced this in commit 296cb3807d on Jul 21, 2022
  18. dhruv referenced this in commit a7efff1c21 on Jul 22, 2022
  19. dhruv referenced this in commit 5667aa958a on Aug 12, 2022
  20. dhruv referenced this in commit 06823cfe29 on Aug 24, 2022
  21. dhruv referenced this in commit 6eca30d4bd on Sep 2, 2022
  22. dhruv referenced this in commit c3ed192dda on Sep 2, 2022
  23. dhruv referenced this in commit 89ebab0601 on Oct 1, 2022
  24. dhruv referenced this in commit d6bcb105c3 on Oct 20, 2022
  25. dhruv referenced this in commit c27eb1e66a on Oct 20, 2022
  26. dhruv referenced this in commit a2e91d2816 on Oct 20, 2022
  27. dhruv referenced this in commit 0b21533c10 on Oct 21, 2022
  28. dhruv referenced this in commit 01dddb4cf6 on Oct 21, 2022
  29. dhruv referenced this in commit a0bb5b6946 on Nov 17, 2022
  30. dhruv referenced this in commit 2e4c03dd67 on Nov 17, 2022
  31. dhruv referenced this in commit 388c9b1b55 on Nov 21, 2022
  32. dhruv referenced this in commit 244eb87643 on Dec 7, 2022
  33. dhruv referenced this in commit 92cddabc43 on Dec 8, 2022
  34. sipa referenced this in commit 9d47e7b71b on Dec 13, 2022
  35. dhruv referenced this in commit 55ffd47cc6 on Dec 14, 2022
  36. dhruv referenced this in commit 967c65b158 on Dec 14, 2022
  37. dhruv referenced this in commit 78b5ddf28b on Jan 11, 2023
  38. dhruv referenced this in commit 215394a1d5 on Jan 11, 2023
  39. div72 referenced this in commit 945b094575 on Mar 14, 2023
  40. str4d referenced this in commit 0df7b459f6 on Apr 21, 2023
  41. vmta referenced this in commit e1120c94a1 on Jun 4, 2023
  42. vmta referenced this in commit 8f03457eed on Jul 1, 2023
  43. jonasnick cross-referenced this on Jul 17, 2023 from issue Upstream PRs 1056, 1104, 1105, 1084, 1114, 1115 by jonasnick
  44. jonasnick cross-referenced this on Jul 17, 2023 from issue Upstream PRs 1056, 1104, 1105, 1084, 1114, 1115 by jonasnick
  45. jonasnick cross-referenced this on Jul 17, 2023 from issue Upstream PRs 1056, 1104, 1105, 1084, 1114, 1115, 1116, 1120, 1122, 1121, 1128, 1131, 1144, 1150, 1146 by jonasnick
Contributors
siv2rjonasnicksipa
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 19:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me