I noticed this in the CI output:
We are sunsetting support for Intel-based macOS instances! Please migrate before January 1st 2023.
-
sipa commented at 10:43 PM on November 14, 2022: contributor
- sipa cross-referenced this on Nov 17, 2022 from issue Update macOS image for CI by sipa
-
MarcoFalke commented at 11:40 AM on November 29, 2022: none
Is this fixed now?
-
real-or-random commented at 12:56 PM on November 29, 2022: contributor
from #1152:
It drops valgrind and the ctime tests on macOS, as valgrind simply isn't supported anymore there. We may recover some of that functionality by adding MSan (https://github.com/bitcoin-core/secp256k1/pull/1155) for memory-checking there, and adding ctime-using-mtime (TODO).
I think we should leave it open until this has been fixed.
- Enable MSan for MacOS
- Make the constant-time tests work on MSan
- real-or-random renamed this:
Cirrus CI sunsetting x86-based macOS support
Constant-time tests with MSan / for MacOS
on Dec 5, 2022 - real-or-random added the label assurance on Jan 5, 2023
-
real-or-random commented at 1:51 PM on January 11, 2023: contributor
Oh, the valgrind fork now works on Ventura https://github.com/LouisBrunner/valgrind-macos/issues/54#issuecomment-1377334552 (except for memory leak tracking, which is still WIP but that shouldn't be required for our purposes.) So we should probably revert https://github.com/bitcoin-core/secp256k1/pull/1152/commits/c0ae48c9950a908b637bff27791fabbe2833c4a5 partly.
- real-or-random cross-referenced this on Apr 12, 2023 from issue test: Silent noisy clang warnings about Valgrind code on macOS x86_64 by hebasto
-
hebasto commented at 10:18 AM on June 5, 2023: member
- Enable MSan for MacOS
https://clang.llvm.org/docs/MemorySanitizer.html#supported-platforms:
MemorySanitizer is supported on the following OS:
- Linux
- NetBSD
- FreeBSD
-
real-or-random commented at 11:09 AM on June 11, 2023: contributor
Oh indeed, MSan doesn't work on macOS...
- Make the constant-time tests work on MSan
And this has been solved by #1169.
This means that there's nothing to do for us here except to wait for https://github.com/LouisBrunner/valgrind-macos/issues/56. This will make it possible to run Valgrind on macOS again.
Leaving this open to track this.
- real-or-random renamed this:
Constant-time tests with MSan / for MacOS
Constant-time tests on macOS
on Jun 11, 2023 - real-or-random cross-referenced this on Aug 16, 2023 from issue ci: Future of CI after Cirrus pricing change by real-or-random
- real-or-random added the label ci on Aug 28, 2023
- real-or-random cross-referenced this on Aug 28, 2023 from issue ci: Switch macOS from Ventura to Monterey and add Valgrind by hebasto
- real-or-random referenced this in commit 65c79fe2d0 on Aug 29, 2023
- real-or-random closed this on Aug 29, 2023
Contributors
Linked (view graph)
#1152 Update macOS image for CI#1155 Add MSan CI jobs#1169 Add support for msan instead of valgrind (for memcheck and ctime test)#1274 test: Silent noisy clang warnings about Valgrind code on macOS x86_64#1392 ci: Future of CI after Cirrus pricing change #1412 ci: Switch macOS from Ventura to Monterey and add Valgrind