The bench and ctime_tests binaries are users of the library, they should only be linked to the library, not the objects it was built from.
Do not link `bench` and `ctime_tests` to `COMMON_LIB` #1203
pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:230130-common changing 1 files +2 −2-
hebasto commented at 10:43 PM on January 30, 2023: member
-
ef39721ccc
Do not link `bench` and `ctime_tests` to `COMMON_LIB`
The `bench` and `ctime_tests` are users of the library, they should only be linked to the library, not the objects it was built from.
-
sipa commented at 11:25 PM on January 30, 2023: contributor
utACK ef39721cccec344983f09180bcf9c443d491f7cb
- hebasto cross-referenced this on Jan 30, 2023 from issue build: Add CMake-based build system by hebasto
- real-or-random approved
-
real-or-random commented at 8:01 AM on January 31, 2023: contributor
utACK ef39721cccec344983f09180bcf9c443d491f7cb
- real-or-random merged this on Jan 31, 2023
- real-or-random closed this on Jan 31, 2023
- hebasto deleted the branch on Jan 31, 2023
- hebasto referenced this in commit 7c0cc5d976 on Mar 7, 2023
- dhruv referenced this in commit a5df79db12 on Mar 7, 2023
- dhruv referenced this in commit 77b510d84c on Mar 7, 2023
- sipa referenced this in commit 763079a3f1 on Mar 8, 2023
- div72 referenced this in commit 945b094575 on Mar 14, 2023
- vmta referenced this in commit e1120c94a1 on Jun 4, 2023
- vmta referenced this in commit 8f03457eed on Jul 1, 2023
- jonasnick cross-referenced this on Jul 20, 2023 from issue Upstream PRs 1160, 1193, 1169, 1190, 1192, 1194, 1196, 1195, 1170, 1172, 1200, 1199, 1203, 1201, 1206, 1078, 1209, 979, 1212, 1218, 1217, 1221, 1222 by jonasnick
Contributors