Apply Checks only in VERIFY mode. #1247

pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:patch-5 changing 1 files +4 −0

roconnor-blockstream commented at 2:07 AM on March 23, 2023: contributor

This is already done in field_5x52_impl.h.
Apply Checks only in VERIFY mode. 4ebd82852d
jonasnick commented at 8:39 AM on March 23, 2023: contributor

If the goal is to make the two files consistent, wouldn't it be better to remove the ifdef from field_5x52_impl.h (EDIT: because we generally don't wrap simple VERIFY_CHECKs in VERIFY ifdefs)?
roconnor-blockstream commented at 12:29 PM on March 23, 2023: contributor

We generally do wrap non-trivial VERIFY_CHECKs, particularly when they call functions.
jonasnick commented at 3:58 PM on March 23, 2023: contributor

You're right.

ACK 4ebd82852d3ad00ab579b26173575a4f4642ea76
roconnor-blockstream commented at 6:21 PM on March 23, 2023: contributor

I do admit, with so many exceptions, the whole idea of enabling VERIY_CHECKs in release builds feels of questionable value.
sipa commented at 1:21 PM on March 24, 2023: contributor

ACK 4ebd82852d3ad00ab579b26173575a4f4642ea76
sipa merged this on Mar 24, 2023
sipa closed this on Mar 24, 2023
roconnor-blockstream deleted the branch on Mar 24, 2023
roconnor-blockstream referenced this in commit 1a7dfb9299 on Mar 24, 2023
roconnor-blockstream referenced this in commit 898381f87c on Mar 24, 2023
sipa referenced this in commit e1552d578e on Apr 11, 2023
sipa referenced this in commit c981671e9b on Apr 14, 2023
apoelstra referenced this in commit 0849ab161c on Apr 28, 2023
hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
RandyMcMillan referenced this in commit 3cc75121b3 on May 27, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023
alokeutpal approved
jonasnick cross-referenced this on Jul 21, 2023 from issue Upstream PRs 1228, 1236, 1243, 1238, 1246, 1247, 1242, 1250, 1244, 1241, 1257, 1226, 1252, 1118, 1245, 1266, 1269 by jonasnick
jonasnick cross-referenced this on Jul 21, 2023 from issue Upstream PRs 1228, 1236, 1243, 1238, 1246, 1247, 1242, 1250, 1244, 1241, 1257, 1226, 1252, 1118, 1245, 1266, 1269 by jonasnick

Contributors