No description provided.
tests: remove extra semicolon in macro #1286
pull jonasnick wants to merge 2 commits into bitcoin-core:master from jonasnick:tests-semicolon changing 2 files +20 −19-
jonasnick commented at 8:22 PM on April 21, 2023: contributor
-
tests: remove extra semicolon in macro 3858bad2c6
-
hebasto commented at 8:56 PM on April 21, 2023: member
Where the
PRINT_BUFmacro is used? -
jonasnick commented at 7:31 AM on April 23, 2023: contributor
@hebasto it was just added with #1205 and not used anywhere as it's intended for development and debugging (see #1205 (comment) for the rationale).
-
real-or-random commented at 10:16 AM on April 25, 2023: contributor
Now I also realized that the current location of the macro and the function are not great because you can use them only in
tests.cbut not in the actual library... Sorry for that. @jonasnick Can you move the macro and the function? I propose to move it to the top ofutil.h, which is included very early. This should do the trick. -
debug: move helper for printing buffers into util.h c4062d6b5d
-
jonasnick commented at 4:08 PM on April 25, 2023: contributor
@real-or-random good point. Moved to
util.h. - real-or-random approved
-
real-or-random commented at 4:14 PM on April 25, 2023: contributor
utACK c4062d6b5d83572c1932f32003a7c0e901fffc23
- hebasto approved
-
hebasto commented at 9:07 PM on April 25, 2023: member
ACK c4062d6b5d83572c1932f32003a7c0e901fffc23, I have reviewed the code and it looks OK.
- real-or-random merged this on Apr 25, 2023
- real-or-random closed this on Apr 25, 2023
- sipa referenced this in commit b4eb644b6c on May 12, 2023
- hebasto referenced this in commit 49c52ea2b1 on May 13, 2023
- vmta referenced this in commit e1120c94a1 on Jun 4, 2023
- sipa referenced this in commit 901336eee7 on Jun 21, 2023
- vmta referenced this in commit 8f03457eed on Jul 1, 2023
- jonasnick cross-referenced this on Jul 24, 2023 from issue Upstream PRs 1268, 1276, 1267, 1265, 1230, 1279, 1273, 1263, 1231, 1285, 1283, 1205, 1286, 1275, 1234, 1239, 1240, 1284, 1277, 1289, 1270, 1296, 1301, 1299, 1066, 1300, 1292, 1305, 1303, 1133, 1306, 1207, 1304, 1307, 1311, 1309, 1312 by jonasnick
